From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Andy Lutomirski <luto@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Brian Gerst <brgerst@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Denys Vlasenko <dvlasenk@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 0/3] x86/entry/64: Fixes for syscall rework
Date: Mon, 1 Feb 2016 08:58:02 +0100 [thread overview]
Message-ID: <20160201075802.GA9299@gmail.com> (raw)
In-Reply-To: <20160131214626.GF22584@pd.tnic>
* Borislav Petkov <bp@alien8.de> wrote:
> On Sun, Jan 31, 2016 at 09:33:25AM -0800, Andy Lutomirski wrote:
> > I broke iopl(2) with my syscall rework. Fix it up. While debugging
> > it, I found a bug in my IRQ state handling. Fix that, too.
> >
> > Andy Lutomirski (3):
> > x86/entry/64: Fix an IRQ state error on ptregs-using syscalls
> > x86/entry/64: Fix fast-path syscall return register state
> > x86/syscalls/64: Mark sys_iopl as using ptregs
> >
> > arch/x86/entry/entry_64.S | 23 ++++++++++++++++-------
> > arch/x86/entry/syscalls/syscall_64.tbl | 2 +-
> > 2 files changed, 17 insertions(+), 8 deletions(-)
>
> Looks good so far:
>
> Reported-and-tested-by: Borislav Petkov <bp@suse.de>
>
> We better hammer on those a lot more until the next merge window for
> more confidence.
Yes, this is why I started merging this right after -rc1.
In particular it would be interesting to get feedback from our 'special' syscall
ABI users: emulators (Wine, Steam, etc.) and non-GNU toolchains (Android-x86) - at
least the ones that utilize 64-bit syscalls.
Thanks,
Ingo
prev parent reply other threads:[~2016-02-01 7:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 17:33 [PATCH 0/3] x86/entry/64: Fixes for syscall rework Andy Lutomirski
2016-01-31 17:33 ` [PATCH 1/3] x86/entry/64: Fix an IRQ state error on ptregs-using syscalls Andy Lutomirski
2016-02-01 8:03 ` [tip:x86/asm] " tip-bot for Andy Lutomirski
2016-01-31 17:33 ` [PATCH 2/3] x86/entry/64: Fix fast-path syscall return register state Andy Lutomirski
2016-02-01 8:03 ` [tip:x86/asm] " tip-bot for Andy Lutomirski
2016-01-31 17:33 ` [PATCH 3/3] x86/syscalls/64: Mark sys_iopl as using ptregs Andy Lutomirski
2016-02-01 8:04 ` [tip:x86/asm] x86/syscalls/64: Mark sys_iopl() " tip-bot for Andy Lutomirski
2016-01-31 21:46 ` [PATCH 0/3] x86/entry/64: Fixes for syscall rework Borislav Petkov
2016-02-01 7:58 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201075802.GA9299@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox