From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751193AbcBAH6J (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Feb 2016 02:58:09 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:36554 "EHLO
	mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750733AbcBAH6H (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Feb 2016 02:58:07 -0500
Date: Mon, 1 Feb 2016 08:58:02 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Andy Lutomirski <luto@kernel.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Brian Gerst <brgerst@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 0/3] x86/entry/64: Fixes for syscall rework
Message-ID: <20160201075802.GA9299@gmail.com>
References: <cover.1454261517.git.luto@kernel.org>
 <20160131214626.GF22584@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160131214626.GF22584@pd.tnic>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Borislav Petkov <bp@alien8.de> wrote:

> On Sun, Jan 31, 2016 at 09:33:25AM -0800, Andy Lutomirski wrote:
> > I broke iopl(2) with my syscall rework.  Fix it up.  While debugging
> > it, I found a bug in my IRQ state handling.  Fix that, too.
> > 
> > Andy Lutomirski (3):
> >   x86/entry/64: Fix an IRQ state error on ptregs-using syscalls
> >   x86/entry/64: Fix fast-path syscall return register state
> >   x86/syscalls/64: Mark sys_iopl as using ptregs
> > 
> >  arch/x86/entry/entry_64.S              | 23 ++++++++++++++++-------
> >  arch/x86/entry/syscalls/syscall_64.tbl |  2 +-
> >  2 files changed, 17 insertions(+), 8 deletions(-)
> 
> Looks good so far:
> 
> Reported-and-tested-by: Borislav Petkov <bp@suse.de>
> 
> We better hammer on those a lot more until the next merge window for
> more confidence.

Yes, this is why I started merging this right after -rc1.

In particular it would be interesting to get feedback from our 'special' syscall 
ABI users: emulators (Wine, Steam, etc.) and non-GNU toolchains (Android-x86) - at 
least the ones that utilize 64-bit syscalls.

Thanks,

	Ingo