From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752902AbcBAJiW (ORCPT ); Mon, 1 Feb 2016 04:38:22 -0500 Received: from mail.skyhub.de ([78.46.96.112]:58896 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752044AbcBAJiU (ORCPT ); Mon, 1 Feb 2016 04:38:20 -0500 Date: Mon, 1 Feb 2016 10:38:09 +0100 From: Borislav Petkov To: Ingo Molnar Cc: Chen Yucong , hpa@zytor.com, tony.luck@intel.com, x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Peter Zijlstra Subject: Re: [PATCH] mcheck/therm_throt: Replace printk(KERN_XX...) with pr_xx(...) Message-ID: <20160201093809.GA6438@pd.tnic> References: <1454312473-2685-1-git-send-email-slaoub@gmail.com> <20160201081951.GA14977@gmail.com> <20160201082412.GA15735@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160201082412.GA15735@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2016 at 09:24:12AM +0100, Ingo Molnar wrote: > > So there are 37,000+ printk() calls in the kernel and 900+ ones in arch/x86/ > > alone! Plus even after this patch there's 20 more printk()s left in > > arch/x86/kernel/cpu/mcheck/... > > > > We don't want to create a churn of 10,000+ commits to convert them to pr_*() > > facilities... > > > > So we don't apply such 'conversion' patches unless it's done for a whole subsystem > > and done as part of a larger work with good reason, or if it's done as part of > > completely new facilities/drivers - and is done consistently. > > > > Even then it's dubious to convert: people keep re-adding printk()s (which is a > > perfectly fine facility), which generates never ending churn ... Amen to that! -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.