From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932786AbcBANK3 (ORCPT ); Mon, 1 Feb 2016 08:10:29 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34626 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932446AbcBANKW (ORCPT ); Mon, 1 Feb 2016 08:10:22 -0500 Date: Mon, 1 Feb 2016 15:10:19 +0200 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, willy@linux.intel.com Subject: Re: [PATCH 4/6] dax: Use PAGE_CACHE_SIZE where appropriate Message-ID: <20160201131019.GC29337@node.shutemov.name> References: <1454242795-18038-1-git-send-email-matthew.r.wilcox@intel.com> <1454242795-18038-5-git-send-email-matthew.r.wilcox@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454242795-18038-5-git-send-email-matthew.r.wilcox@intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 31, 2016 at 11:19:53PM +1100, Matthew Wilcox wrote: > We were a little sloppy about using PAGE_SIZE instead of PAGE_CACHE_SIZE. PAGE_CACHE_SIZE is non-sense. It never had any meaning. At least in upstream. And only leads to confusion on border between vfs and mm. We should just drop it. I need to find time at some point to prepare patchset... -- Kirill A. Shutemov