From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932921AbcBAOW4 (ORCPT ); Mon, 1 Feb 2016 09:22:56 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35463 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932417AbcBAOWy (ORCPT ); Mon, 1 Feb 2016 09:22:54 -0500 Date: Mon, 1 Feb 2016 15:23:19 +0100 From: Christoffer Dall To: Marc Zyngier Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH v2 15/21] arm64: KVM: VHE: Use unified sysreg accessors for timer Message-ID: <20160201142319.GU1478@cbox> References: <1453737235-16522-1-git-send-email-marc.zyngier@arm.com> <1453737235-16522-16-git-send-email-marc.zyngier@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453737235-16522-16-git-send-email-marc.zyngier@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 25, 2016 at 03:53:49PM +0000, Marc Zyngier wrote: > Switch the timer code to the unified sysreg accessors. > > Signed-off-by: Marc Zyngier Reviewed-by: Christoffer Dall > --- > arch/arm64/kvm/hyp/timer-sr.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/timer-sr.c b/arch/arm64/kvm/hyp/timer-sr.c > index 1051e5d..f276d9e 100644 > --- a/arch/arm64/kvm/hyp/timer-sr.c > +++ b/arch/arm64/kvm/hyp/timer-sr.c > @@ -31,12 +31,12 @@ void __hyp_text __timer_save_state(struct kvm_vcpu *vcpu) > u64 val; > > if (kvm->arch.timer.enabled) { > - timer->cntv_ctl = read_sysreg(cntv_ctl_el0); > - timer->cntv_cval = read_sysreg(cntv_cval_el0); > + timer->cntv_ctl = read_sysreg_el0(cntv_ctl); > + timer->cntv_cval = read_sysreg_el0(cntv_cval); > } > > /* Disable the virtual timer */ > - write_sysreg(0, cntv_ctl_el0); > + write_sysreg_el0(0, cntv_ctl); > > /* Allow physical timer/counter access for the host */ > val = read_sysreg(cnthctl_el2); > @@ -64,8 +64,8 @@ void __hyp_text __timer_restore_state(struct kvm_vcpu *vcpu) > > if (kvm->arch.timer.enabled) { > write_sysreg(kvm->arch.timer.cntvoff, cntvoff_el2); > - write_sysreg(timer->cntv_cval, cntv_cval_el0); > + write_sysreg_el0(timer->cntv_cval, cntv_cval); > isb(); > - write_sysreg(timer->cntv_ctl, cntv_ctl_el0); > + write_sysreg_el0(timer->cntv_ctl, cntv_ctl); > } > } > -- > 2.1.4 >