From: Brian Norris <computersforpeace@gmail.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: nand: pxa3xx_nand: add register access debug
Date: Mon, 1 Feb 2016 10:00:03 -0800 [thread overview]
Message-ID: <20160201180003.GG19540@google.com> (raw)
In-Reply-To: <20160129144707.GB1437@laptop.cereza>
On Fri, Jan 29, 2016 at 11:47:07AM -0300, Ezequiel Garcia wrote:
> On 25 Jan 09:29 PM, Robert Jarzmik wrote:
> > Add verbose debug for register accesses. This enables easier debugging
> > by following where and how hardware is stimulated, and how it answers.
> >
> > Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> > ---
[...]
>
> With verbose debug enabled, it looks like this:
>
> [..]
> [ 99.909883] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():793 nand_readl(0x0014): 0x1
> [ 99.909896] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():843 nand_writel(0x1, 0x0014)
> [ 99.909902] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():857 nand_writel(0x300d3000, 0x0048)
> [ 99.909909] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():858 nand_writel(0x60000, 0x0048)
> [ 99.909915] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():859 nand_writel(0x0, 0x0048)
> [ 99.909921] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():863 nand_writel(0x820, 0x0048)
> [ 99.910037] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():793 nand_readl(0x0014): 0x2
>
> Maybe it would look clearer with:
>
> [ 99.910037] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():793 nand_readl(0x0014) = 0x2
Seems reasonable. I made that change myself, and applied it to
l2-mtd.git.
> But if you feel it's just bikeshedding then:
Maybe :)
> Acked-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Thanks!
next prev parent reply other threads:[~2016-02-01 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 20:29 [PATCH v2] mtd: nand: pxa3xx_nand: add register access debug Robert Jarzmik
2016-01-29 14:47 ` Ezequiel Garcia
2016-02-01 18:00 ` Brian Norris [this message]
2016-02-01 19:39 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201180003.GG19540@google.com \
--to=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox