public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Linux 4.5-rc2
@ 2016-02-01  2:28 Linus Torvalds
  2016-02-01 13:19 ` Harald Arnesen
  2016-02-01 19:08 ` Heinz Diehl
  0 siblings, 2 replies; 9+ messages in thread
From: Linus Torvalds @ 2016-02-01  2:28 UTC (permalink / raw)
  To: Linux Kernel Mailing List

As late as Friday, I was planning on talking about how nice it is to
see this new trend of tiny rc2 releases, because there really hadn't
been very many pull requests at all.

But it turns out the pull requests were just heavily skewed to the end
of the week, and 4.5-rc2 isn't particularly small after all. It pretty
much doubled over the weekend.

Not that it's all that big anyway, and skewing towards the end of the
week probably makes sense for rc2 - it takes some time to start
finding the problems that the merge window has brought with it. So
this odd behavior doesn't worry me, it seems fairly natural.

As to the kinds of patches we have here: the appended shortlog gives
more details, but it's pretty much all over. Drivers and architecture
updates are only about half of the patch, with perf fixes and some of
the new virtio self-tests being much of the rest. There's some btrfs
fixes too.

None of it is all that big, though.

Go forth and test,

                 Linus

---

Aaron Plattner (1):
      ALSA: hda - Add new GPU codec ID 0x10de0083 to snd-hda

Alan Modra (1):
      powerpc: Simplify module TOC handling

Alan Stern (1):
      SCSI: fix crashes in sd and sr runtime PM

Alex Deucher (5):
      drm/amdgpu: fix tonga smu resume
      drm/amdgpu: Add some tweaks to gfx 8 soft reset
      drm/amdgpu: add a message to indicate when powerplay is enabled (v2)
      drm/radeon: properly byte swap vce firmware setup
      drm/amdgpu: don't init fbdev if we don't have any connectors

Alex Thorlton (1):
      x86/platform/UV: Remove EFI memmap quirk for UV2+

Alex Williamson (1):
      vfio/noiommu: Don't use iommu_present() to track fake groups

Alexander Shishkin (1):
      perf: Synchronously free aux pages in case of allocation failure

Alexandre Belloni (1):
      clockevents/tcb_clksrc: Prevent disabling an already disabled clock

Alexei Starovoitov (1):
      perf/bpf: Convert perf_event_array to use struct file

Alexey Kardashevskiy (1):
      KVM doc: Fix KVM_SMI chapter number

Anders Roxell (1):
      cpuidle: coupled: remove unused define cpuidle_coupled_lock

Andrzej Hajda (1):
      drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp result

Andy Shevchenko (4):
      x86/platform/intel-mid: Enable 64-bit build
      x86/platform/intel-mid: Join string and fix SoC name
      x86/platform/quark: Print boundaries correctly
      i2c: designware-pci: use IRQF_COND_SUSPEND flag

Aneesh Kumar K.V (1):
      powerpc/mm: Fixup _HPAGE_CHG_MASK

Antonio Ospite (1):
      mailmap: redirect inactive address <ao2@amarulasolutions.com>

Ard Biesheuvel (2):
      arm64: hide __efistub_ aliases from kallsyms
      arm64: kasan: ensure that the KASAN zero page is mapped read-only

Arnd Bergmann (6):
      irqchip/s3c24xx: Mark init_eint as __maybe_unused
      tick/sched: Hide unused oneshot timer code
      clocksource: Select CLKSRC_MMIO where needed
      PM: APM_EMULATION does not depend on PM
      cpufreq: pxa2xx: fix pxa_cpufreq_change_voltage prototype
      cpufreq: cpufreq-dt: avoid uninitialized variable warnings:

Baoquan He (1):
      iommu/amd: Correct the wrong setting of alias DTE in do_attach

Ben Hutchings (1):
      perf symbols: Fix reading of build-id from vDSO

Catalin Marinas (1):
      arm64: Honour !PTE_WRITE in set_pte_at() for kernel mappings

Chandan Rajendra (1):
      powerpc: Wire up copy_file_range() syscall

Chen Gang (1):
      include/linux/cleancache.h: Clean up code

Chris Mason (2):
      btrfs: don't use GFP_HIGHMEM for free-space-tree bitmap kzalloc
      Revert "btrfs: synchronize incompat feature bits with sysfs files"

Christian Borntraeger (2):
      s390/irqflags: optimize irq restore
      debugobjects: Allow bigger number of early boot objects

Christian König (2):
      drm/amdgpu: fix amdgpu_bo_pin_restricted VRAM placing v2
      drm/amdgpu: fix next_rptr handling for debugfs

Daniele Palmas (1):
      USB: serial: option: Adding support for Telit LE922

David Hildenbrand (2):
      KVM: s390: fix guest fprs memory leak
      KVM: s390: fix memory overwrites when vx is disabled

David Howells (1):
      KEYS: Only apply KEY_FLAG_KEEP to a key if a parent keyring has it set

David Sterba (10):
      btrfs: sysfs: fix typo in compat_ro attribute definition
      btrfs: sysfs: add free-space-tree bit attribute
      btrfs: sysfs: introduce helper for syncing bits with sysfs files
      btrfs: synchronize incompat feature bits with sysfs files
      btrfs: tests: switch to GFP_KERNEL
      btrfs: tweak free space tree bitmap allocation
      btrfs: add free space tree to lockdep classes
      btrfs: add free space tree to the cow-only list
      Revert "btrfs: clear PF_NOFREEZE in cleaner_kthread()"
      btrfs: sysfs: check initialization state before updating features

Dmitry Safonov (1):
      ftrace: Remove unused nr_trampolines var

Dominik Dingel (1):
      s390/mm: use TASK_MAX_SIZE where applicable

Dong Jia Shi (1):
      KVM: s390: Enable the KVM-VFIO device

Du, Changbin (1):
      usb: hub: do not clear BOS field during reset device

Eric Anholt (1):
      drm/vc4: Remove broken attempt at GPU reset using genpd.

Eric Huang (1):
      drm/amd/amdgpu: Improve amdgpu_dpm* macros to avoid unexpected result (v2)

Fabio Estevam (1):
      drm/etnaviv: remove owner assignment from platform_driver

Fengguang Wu (1):
      MAINTAINERS: add git URL for swiotlb

Filipe Manana (1):
      Btrfs: fix race between fsync and lockless direct IO writes

Gautham R Shenoy (1):
      cpufreq: Use list_is_last() to check last entry of the policy list

Gavin Guo (1):
      sched/numa: Fix use-after-free bug in the task_numa_compare

Gavin Shan (1):
      powerpc/eeh: Fix PE location code

Geert Uytterhoeven (2):
      hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA
      hisi_sas: Restrict SCSI_HISI_SAS to arm64

Geyslan G. Bem (1):
      KVM: PPC: Book3S PR: Remove unused variable 'vcpu_book3s'

Gioh Kim (1):
      hwmon: (fam15h_power) Add bit masking for tdp_limit

Greg Kroah-Hartman (1):
      USB: serial: ftdi_sio: add support for Yaesu SCU-18 cable

Greg Kurz (1):
      KVM: PPC: Fix ONE_REG AltiVec support

Guillaume Fougnies (1):
      ALSA: usb-audio: Fix TEAC UD-501/UD-503/NT-503 usb delay

Gustavo Padovan (1):
      tracing/dma-buf/fence: Fix timeline str value on fence_annotate_wait_on

Hans de Goede (1):
      ACPI: Revert "ACPI / video: Add Dell Inspiron 5737 to the blacklist"

Heiko Carstens (5):
      s390/numa: allocate memory with correct alignment
      s390: remove superfluous memblock_alloc() return value checks
      s390: wire up copy_file_range syscall
      s390: remove all usages of PSW_ADDR_AMODE
      s390: remove all usages of PSW_ADDR_INSN

Ingo Tuchscherer (1):
      s390/zcrypt: Fix cryptographic device id in kernel messages

Insu Yun (1):
      ACPI / PCI / hotplug: unlock in error path in acpiphp_enable_slot()

Jan Beulich (1):
      x86/mm: Fix types used in pgprot cacheability flags translations

Jann Horn (1):
      seccomp: always propagate NO_NEW_PRIVS on tsync

Jean Delvare (3):
      i2c: piix4: Fix SB800 locking
      i2c: piix4: Fully initialize SB800 before it is registered
      i2c: piix4: don't regress on bus names

Jeremy McNicoll (1):
      iommu/vt-d: Don't skip PCI devices when disabling IOTLB

Jiang Liu (2):
      x86/irq: Fix a race in x86_vector_free_irqs()
      x86/irq: Do not use apic_chip_data.old_domain as temporary buffer

Jiri Olsa (4):
      perf build: Add feature-dump target
      perf build: Introduce FEATURES_DUMP make variable
      perf hists: Fix HISTC_MEM_DCACHELINE width setting
      perf stat: Do not clean event's private stats

Johan Hovold (1):
      USB: visor: fix null-deref at probe

John Ernberg (1):
      USB: option: fix Cinterion AHxx enumeration

John Keeping (5):
      drm/rockchip: vop: fix mask when updating interrupts
      drm/atomic-helper: Export framebuffer_changed()
      drm/rockchip: don't wait for vblank if fb hasn't changed
      drm/rockchip: explain why we can't wait_for_vblanks
      drm/rockchip: respect CONFIG_DRM_FBDEV_EMULATION

John Stultz (2):
      ntp: Fix ADJ_SETOFFSET being used w/ ADJ_NANO
      kselftests: timers: Add adjtimex SETOFFSET validity tests

Jordan Lazare (1):
      drm/amdgpu: Allow the driver to load if amdgpu.powerplay=1 on
asics without powerplay support

Julia Lawall (1):
      cleancache: constify cleancache_ops structure

Kees Cook (1):
      ARM: 8500/1: fix atags_to_fdt with stack-protector-strong

Lada Trimasova (1):
      iommu/io-pgtable-arm: Fix io-pgtable-arm build failure

Lars-Peter Clausen (1):
      iio: adis_buffer: Fix out-of-bounds memory access

Libin Yang (1):
      ALSA: hda - disable dynamic clock gating on Broxton before reset

Linus Torvalds (1):
      Linux 4.5-rc2

Lorenzo Pieralisi (1):
      arm64: kernel: fix architected PMU registers unconditional access

Lu Baolu (2):
      usb: cdc-acm: handle unlinked urb in acm read callback
      usb: cdc-acm: send zero packet for intel 7260 modem

Lucas Stach (5):
      drm/etnaviv: hold object lock while getting pages for coredump
      drm/etnaviv: fix memory leak in IOMMU init path
      drm/etnaviv: fix get pages error path in etnaviv_gem_vaddr
      drm/etnaviv: rename etnaviv_gem_vaddr to etnaviv_gem_vmap
      drm/etnaviv: call correct function when trying to vmap a DMABUF

Lucas Tanure (1):
      ALSA: bebob: Use a signed return type for get_formation_index

Madhavan Srinivasan (1):
      powerpc/perf: Remove PPMU_HAS_SSLOT flag for Power8

Magnus Damm (1):
      iommu: Update struct iommu_ops comments

Marc Zyngier (3):
      irqdomain: Allow domain lookup with DOMAIN_BUS_WIRED token
      of: MSI: Simplify irqdomain lookup
      irqchip/gic-v3-its: Recompute the number of pages on page size change

Marek Szyprowski (1):
      PM / domains: fix lockdep issue for all subdomains

Mark Yao (3):
      drm/rockchip: Don't build rockchip_drm_vop as modules
      drm/rockchip: cleanup unnecessary export symbol
      drm/rockchip: fix wrong pitch/size using on gem

Markus Trippelsdorf (2):
      perf tests: Remove wrong semicolon in while loop in CQM test
      perf annotate browser: Fix behaviour of Shift-Tab with nothing focussed

Martin K. Petersen (1):
      sd: Optimal I/O size is in bytes, not sectors

Martin Wilck (1):
      base/platform: Fix platform drivers with no probe callback

Masanari Iida (1):
      arm64: Fix an enum typo in mm/dump.c

Mathieu OTHACEHE (1):
      USB: mxu11x0: fix memory leak on usb_serial private data

Matt Fleming (1):
      x86/mm/pat: Avoid truncation when converting cpa->numpages to address

Matthew Dawson (1):
      drm/radeon: Ensure radeon bo is unreserved in radeon_gem_va_ioctl

Michael Holzheu (1):
      s390/numa: move numa_init_late() from device to arch_initcall

Michael S. Tsirkin (5):
      virtio_pci: fix use after free on release
      tools/virtio: use virt_xxx barriers
      sh: fix smp_store_mb for !SMP
      tools/virtio: add ringtest utilities
      iommu/vt-d: Fix link to Intel IOMMU Specification

Michel Dänzer (1):
      drm/amdgpu: Use drm_calloc_large for VM page_tables array

Mika Penttilä (1):
      arm64: mm: avoid calling apply_to_page_range on empty range

Mika Westerberg (1):
      serial: 8250_pci: Add Intel Broadwell ports

Milo Kim (1):
      irqchip/atmel-aic: Fix wrong bit operation for IRQ priority

Ming Lei (1):
      block: fix bio splitting on max sectors

Moritz Fischer (1):
      PM / Domains: Fix typo in comment

Nicolai Hähnle (1):
      drm/amdgpu: only move pt bos in LRU list on success

Oleksij Rempel (1):
      irqchip/mxs: Add missing set_handle_irq()

Oliver Neukum (1):
      cdc-acm:exclude Samsung phone 04e8:685d

Paul Mackerras (1):
      KVM: PPC: Book3S HV: Handle unexpected traps in guest entry/exit
code better

Peter Dedecker (1):
      USB: cp210x: add ID for IAI USB to RS485 adaptor

Peter Hurley (5):
      tty: Wait interruptibly for tty lock on reopen
      tty: Retry failed reopen if tty teardown in-progress
      tty: Fix unsafe ldisc reference via ioctl(TIOCGETD)
      n_tty: Fix unsafe reference to "other" ldisc
      staging/speakup: Use tty_ldisc_ref() for paste kworker

Peter Zijlstra (28):
      perf: Add lockdep assertions
      perf: Fix cgroup event scheduling
      perf: Fix cgroup scheduling in perf_enable_on_exec()
      perf: Remove stale comment
      perf: Fix perf_enable_on_exec() event scheduling
      perf: Use task_ctx_sched_out()
      perf: Simplify/fix perf_event_enable() event scheduling
      perf: Optimize perf_sched_events() usage
      perf: Make ctx->is_active and cpuctx->task_ctx consistent
      perf: Fix task context scheduling
      perf: Specialize perf_event_exit_task()
      perf: Collapse and fix event_function_call() users
      perf: Add more assertions
      perf: Fix perf_event_exit_task() race
      perf: Fix orphan hole
      perf: Fix race in perf_event_exit_task_context()
      perf/x86: Fix uninitialized value usage
      perf/x86: De-obfuscate code
      perf: Fix NULL deref
      perf: Remove __free_event()
      perf: Update locking order
      perf: Fix STATE_EXIT usage
      perf: Robustify event->owner usage and SMP ordering
      perf: Clean up sync_child_event()
      perf: Add flags argument to perf_remove_from_context()
      perf: Untangle 'owner' confusion
      perf: Synchronously clean up child events
      perf: Remove/simplify lockdep annotation

Qu Wenruo (1):
      btrfs: async-thread: Fix a use-after-free error for trace

Raghavendra K T (1):
      sched: Fix crash in sched_init_numa()

Ralf Baechle (1):
      Revert "MIPS: bcm63xx: nvram: Remove unused
bcm63xx_nvram_get_psi_size() function"

Randy Dunlap (1):
      ALSA: timer: fix SND_PCM_TIMER Kconfig text

Ravi Bangoria (1):
      perf kvm record/report: 'unprocessable sample' error while
recording/reporting guest data

Rex Zhu (1):
      drm/amd/powerplay: Update SMU firmware loading for Stoney

Richard Weinberger (2):
      irqchip: Fix dependencies for archs w/o HAS_IOMEM
      clocksource: Fix dependencies for archs w/o HAS_IOMEM

Rob Clark (2):
      drm/radeon: only init fbdev if we have connectors
      drm/vmwgfx: respect 'nomodeset'

Russell King (8):
      drm/etnaviv: fix failure path if model is zero
      drm/etnaviv: ignore VG GPUs with FE2.0
      drm/etnaviv: update common and state_hi xml.h files
      drm/etnaviv: use defined constants for the chip model
      drm/etnaviv: add helper to extract bitfields
      drm/etnaviv: add helper for comparing model/revision IDs
      drm/etnaviv: add further minor features and varyings count
      ARM: wire up copy_file_range() syscall

Samuel Thibault (2):
      Staging: speakup: Fix getting port information
      Staging: speakup: fix read scrolled-back VT

Sebastian Ott (10):
      s390/pci: adjust IOMAP_MAX_ENTRIES
      s390/pci: provide ZPCI_ADDR macro
      s390/pci: improve ZPCI_* macros
      s390/pci: resize iomap
      s390/pci: fix bar check
      s390/pci: set error state for unusable functions
      s390/pci: remove iomap sanity checks
      s390/cio: fix measurement characteristics memleak
      s390/cio: ensure consistent measurement state
      s390/cio: update measurement characteristics

Slava Grigorev (3):
      drm/radeon: cleaned up VCO output settings for DP audio
      drm/radeon: Add a common function for DFS handling
      drm/radeon: fix DP audio support for APU with DCE4.1 display engine

Stephane Eranian (1):
      perf/x86: add Intel SkyLake uncore IMC PMU support

Stephen Rothwell (1):
      powerpc: Remove newly added extra definition of pmd_dirty

Steven Rostedt (Red Hat) (1):
      tracing: Fix stacktrace skip depth in trace_buffer_unlock_commit_regs()

Sudeep Holla (1):
      cpuidle: fix fallback mechanism for suspend to idle in absence
of enter_freeze

Sudip Mukherjee (1):
      Revert "Staging: panel: usleep_range is preferred over udelay"

Takashi Iwai (5):
      ALSA: seq: Fix incorrect sanity check at snd_seq_oss_synth_cleanup()
      ALSA: seq: Degrade the error message for too many opens
      ALSA: compress: Disable GET_CODEC_CAPS ioctl for some architectures
      ALSA: Add missing dependency on CONFIG_SND_TIMER
      ALSA: dummy: Disable switching timer backend via sysfs

Thierry Reding (1):
      swiotlb: Make linux/swiotlb.h standalone includible

Thomas Gleixner (19):
      genirq: Validate action before dereferencing it in
handle_irq_event_percpu()
      x86/irq: Call chip->irq_set_affinity in proper context
      x86/irq: Validate that irq descriptor is still active
      x86/irq: Reorganize the return path in assign_irq_vector
      x86/irq: Reorganize the search in assign_irq_vector
      x86/irq: Check vector allocation early
      x86/irq: Copy vectormask instead of an AND operation
      x86/irq: Get rid of code duplication
      x86/irq: Remove offline cpus from vector cleanup
      x86/irq: Clear move_in_progress before sending cleanup IPI
      x86/irq: Remove the cpumask allocation from send_cleanup_vector()
      x86/irq: Remove outgoing CPU from vector cleanup mask
      x86/irq: Call irq_force_move_complete with irq descriptor
      x86/irq: Plug vector cleanup race
      hrtimer: Handle remaining time proper for TIME_LOW_RES
      timerfd: Handle relative timers with CONFIG_TIME_LOW_RES proper
      posix-timers: Handle relative timers with CONFIG_TIME_LOW_RES proper
      itimers: Handle relative timers with CONFIG_TIME_LOW_RES proper
      rtmutex: Make wait_lock irq safe

Thomas Huth (2):
      KVM: PPC: Fix emulation of H_SET_DABR/X on POWER8
      KVM: PPC: Increase memslots to 512

Thomas Petazzoni (1):
      base: Export platform_msi_domain_[alloc,free]_irqs

Thorsten Leemhuis (1):
      hwmon: (dell-smm) Blacklist Dell Studio XPS 8000

Ulf Hansson (1):
      PM / Domains: Fix potential deadlock while adding/removing subdomains

Vasant Hegde (1):
      powerpc/mm: Allow user space to map rtas_rmo_buf

Viresh Kumar (1):
      cpufreq: Fix NULL reference crash while accessing policy->governor_data

Vladis Dronov (1):
      USB: serial: visor: fix crash on detecting device without write_urbs

Wang Nan (4):
      perf build: Set parallel making options build-test
      perf build: Pass O option to Makefile.perf in build-test
      perf build: Test correct path of perf in build-test
      perf build: Pass O option to kernel makefile in build-test

Wanpeng Li (1):
      tick/nohz: Set the correct expiry when switching to nohz/lowres mode

Will Deacon (1):
      arm64: defconfig: updates for 4.5

William Cohen (1):
      Eliminate the .eh_frame sections from the aarch64 vmlinux and
kernel modules

Zhen Lei (1):
      pid: Fix spelling in comments

dann frazier (1):
      arm64: errata: Add -mpc-relative-literal-loads to build flags

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Linux 4.5-rc2
  2016-02-01  2:28 Linux 4.5-rc2 Linus Torvalds
@ 2016-02-01 13:19 ` Harald Arnesen
  2016-02-01 14:18   ` Gerd Hoffmann
  2016-02-01 19:08 ` Heinz Diehl
  1 sibling, 1 reply; 9+ messages in thread
From: Harald Arnesen @ 2016-02-01 13:19 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Linux Kernel Mailing List, Bjørn Mork, Gerd Hoffmann,
	Daniel Vetter, Jani Nikula, intel-gfx

I still get the blank screen than Bjørn Mork reported and bisected when
4.5-rc1 was released.

Reverting this commit fixes it:

HEAD is now at 39bfcd5235e0 drm/i915: more virtual south bridge detection
39bfcd5235e07e95ad3e70eab8e0b85db181de9e is the first bad commit
commit 39bfcd5235e07e95ad3e70eab8e0b85db181de9e
Author: Gerd Hoffmann <kraxel@redhat.com>
Date:   Thu Nov 26 12:03:51 2015 +0100

    drm/i915: more virtual south bridge detection

    Commit "30c964a drm/i915: Detect virtual south bridge" detects and
    handles the southbridge emulated by vmware esx.  Add the ich9 south
    bridge emulated by 'qemu -M q35'.

    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

:040000 040000 b59ceb519d517a00e41e575346505b9ebde06288
825eb4e5684952de0931312183d1cf163c43219a M      drivers
-- 
Hilsen Harald

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Linux 4.5-rc2
  2016-02-01 13:19 ` Harald Arnesen
@ 2016-02-01 14:18   ` Gerd Hoffmann
  2016-02-01 15:19     ` Harald Arnesen
  0 siblings, 1 reply; 9+ messages in thread
From: Gerd Hoffmann @ 2016-02-01 14:18 UTC (permalink / raw)
  To: Harald Arnesen
  Cc: Linus Torvalds, Linux Kernel Mailing List, Bjørn Mork,
	Daniel Vetter, Jani Nikula, intel-gfx

On Mo, 2016-02-01 at 14:19 +0100, Harald Arnesen wrote:
> I still get the blank screen than Bjørn Mork reported and bisected when
> 4.5-rc1 was released.
> 
> Reverting this commit fixes it:
> 
> HEAD is now at 39bfcd5235e0 drm/i915: more virtual south bridge detection
> 39bfcd5235e07e95ad3e70eab8e0b85db181de9e is the first bad commit
> commit 39bfcd5235e07e95ad3e70eab8e0b85db181de9e
> Author: Gerd Hoffmann <kraxel@redhat.com>
> Date:   Thu Nov 26 12:03:51 2015 +0100
> 
>     drm/i915: more virtual south bridge detection
> 
>     Commit "30c964a drm/i915: Detect virtual south bridge" detects and
>     handles the southbridge emulated by vmware esx.  Add the ich9 south
>     bridge emulated by 'qemu -M q35'.
> 
>     Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> :040000 040000 b59ceb519d517a00e41e575346505b9ebde06288
> 825eb4e5684952de0931312183d1cf163c43219a M      drivers

Fix[1] is already queued by Jani Nikula, I suspect it simply missed the
boat because there was no drm-intel-fixes merge in -rc2.

cheers,
  Gerd

[1] https://lkml.org/lkml/2016/1/25/280

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Linux 4.5-rc2
  2016-02-01 14:18   ` Gerd Hoffmann
@ 2016-02-01 15:19     ` Harald Arnesen
  0 siblings, 0 replies; 9+ messages in thread
From: Harald Arnesen @ 2016-02-01 15:19 UTC (permalink / raw)
  To: Gerd Hoffmann
  Cc: Linus Torvalds, Linux Kernel Mailing List, Bjørn Mork,
	Daniel Vetter, Jani Nikula, intel-gfx

Gerd Hoffmann [2016-02-01 15:18]:

> n Mo, 2016-02-01 at 14:19 +0100, Harald Arnesen wrote:
>> I still get the blank screen than Bjørn Mork reported and bisected when
>> 4.5-rc1 was released.
>
> Fix[1] is already queued by Jani Nikula, I suspect it simply missed the
> boat because there was no drm-intel-fixes merge in -rc2.

Confirmed, this patch fixes the bug.
-- 
Hilsen Harald

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Linux 4.5-rc2
  2016-02-01  2:28 Linux 4.5-rc2 Linus Torvalds
  2016-02-01 13:19 ` Harald Arnesen
@ 2016-02-01 19:08 ` Heinz Diehl
  2016-02-01 20:41   ` Greg KH
  2016-02-01 20:46   ` Linus Torvalds
  1 sibling, 2 replies; 9+ messages in thread
From: Heinz Diehl @ 2016-02-01 19:08 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, stable

Hi,

On 01.02.2016, Linus Torvalds wrote: 

> Go forth and test,
> 
>                  Linus

Still, some Asus laptops are hanging at boot-time, both with latest
-stable and 4.5-rc1/rc2:

[    4.056862] asus_laptop:    model detected
[    4.058731] BUG: unable to handle kernel NULL pointer dereference at 0000000000000e20
[    4.060018] IP: [<ffffffffc03d3423>] asus_sysfs_is_visible+0x13/0x1d0 [asus_laptop]
[    4.061346] PGD 0
[    4.062629] Oops: 0000 [#1] PREEMPT SMP
[    4.063960] Modules linked in: wmi asus_laptop(+) input_polldev sparse_keymap rfkill nfsd auth_rpcgss oid_registry nfs_acl lockd grace sunrpc sch_fq_codel tcp_westwood xfs libcrc32c
+hid_logitech_dj crc32c_intel serio_raw atl1c i915 i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops drm i2c_core video
[    4.067026] CPU: 1 PID: 536 Comm: systemd-udevd Not tainted 4.4.0 #1
[    4.068515] Hardware name: ASUSTeK Computer Inc.         U45JC/U45JC, BIOS U45JC.208 02/24/2011
[    4.070023] task: ffff88003645b680 ti: ffff8800a4a0c000 task.ti: ffff8800a4a0c000
[    4.071568] RIP: 0010:[<ffffffffc03d3423>]  [<ffffffffc03d3423>] asus_sysfs_is_visible+0x13/0x1d0 [asus_laptop]
[    4.073188] RSP: 0000:ffff8800a4a0faf8  EFLAGS: 00010282
[    4.074820] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
[    4.076462] RDX: 0000000000000000 RSI: ffffffffc03d63c0 RDI: ffff88003675b420
[    4.078109] RBP: ffff8800a4a0fb08 R08: ffff8801428940c8 R09: 0000000000000124
[    4.079777] R10: ffff88014348d100 R11: 0000000000000014 R12: ffffffffc03d4940
[    4.081470] R13: 0000000000000000 R14: ffff8801418af000 R15: ffffffffc03d6220
[    4.083156] FS:  00007f58ba6dd8c0(0000) GS:ffff880147c40000(0000) knlGS:0000000000000000
[    4.084885] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    4.086611] CR2: 0000000000000e20 CR3: 00000000a49f3000 CR4: 00000000000006e0
[    4.088351] Stack:
[    4.090066]  0000000000000000 ffffffffc03d4940 ffff8800a4a0fb50 ffffffff8122d12b
[    4.091838]  0000000000000000 ffff88003675b420 ffff880141327000 0000000000000000
[    4.093606]  0000000000000000 ffff880036b42498 0000000000000001 ffff8800a4a0fb60
[    4.095386] Call Trace:
[    4.097151]  [<ffffffff8122d12b>] internal_create_group+0xbb/0x310
[    4.098943]  [<ffffffff8122d393>] sysfs_create_group+0x13/0x20
[    4.100748]  [<ffffffffc03d292b>] asus_acpi_add+0x3bb/0xea0 [asus_laptop]
[    4.102583]  [<ffffffff81399d32>] acpi_device_probe+0x4f/0xf5
[    4.104415]  [<ffffffff81431107>] driver_probe_device+0x167/0x490
[    4.106254]  [<ffffffff814314b4>] __driver_attach+0x84/0x90
[    4.108087]  [<ffffffff81431430>] ? driver_probe_device+0x490/0x490
[    4.109931]  [<ffffffff8142ee34>] bus_for_each_dev+0x64/0xa0
[    4.111724]  [<ffffffff814309ae>] driver_attach+0x1e/0x20
[    4.113509]  [<ffffffff8143053b>] bus_add_driver+0x1eb/0x280
[    4.115273]  [<ffffffffc03da000>] ? 0xffffffffc03da000
[    4.117032]  [<ffffffff81431d10>] driver_register+0x60/0xe0
[    4.118818]  [<ffffffff81399c01>] acpi_bus_register_driver+0x38/0x40
[    4.120619]  [<ffffffffc03da02a>] asus_laptop_init+0x2a/0x1000 [asus_laptop]
[    4.122433]  [<ffffffff810003db>] do_one_initcall+0xab/0x1c0
[    4.124276]  [<ffffffff8114b43e>] do_init_module+0x5f/0x1e5
[    4.126114]  [<ffffffff810d8dff>] load_module+0x1f3f/0x2530
[    4.127943]  [<ffffffff810d5500>] ? __symbol_put+0x50/0x50
[    4.129786]  [<ffffffff810d581b>] ? copy_module_from_fd.isra.50+0xdb/0x130
[    4.131653]  [<ffffffff810d95ea>] SyS_finit_module+0x9a/0xc0
[    4.133521]  [<ffffffff816bacd7>] entry_SYSCALL_64_fastpath+0x12/0x6a
[    4.135378] Code: c7 80 48 3d c0 e8 11 7e d7 c0 4c 89 f7 e8 66 3c e5 ff e9 27 ff ff ff 90 66 66 66 66 90 55 48 89 e5 41 54 53 48 8b 8790 00 00 00 <4c> 8b a0 20 0e 00 00 0f b6 80 95 0d 00 00 84 c0 74 1a 48 81 fe
[    4.139719] RIP  [<ffffffffc03d3423>] asus_sysfs_is_visible+0x13/0x1d0 [asus_laptop]
[    4.141788]  RSP <ffff8800a4a0faf8>
[    4.143809] CR2: 0000000000000e20
[    4.145867] ---[ end trace 7d8d7d572a3e9126 ]---

The bug is also reported here:
https://bugzilla.kernel.org/show_bug.cgi?id=110751

This patch fixes the problem (both for me and others):

From: Martin Wilck <Martin.Wilck@ts.fujitsu.com>

Since b8b2c7d845d5, platform_drv_probe() is called for all platform
devices. If drv->probe is NULL, and dev_pm_domain_attach() fails,
platform_drv_probe() will return the error code from dev_pm_domain_attach().

This causes real_probe() to enter the "probe_failed" path and set
dev->driver to NULL. Before b8b2c7d845d5, real_probe() would assume
success if both dev->bus->probe and drv->probe were missing. As a result,
a device and driver could be "bound" together just by matching their names;
this doesn't work any more after b8b2c7d845d5.

This change broke the assumptions of certain drivers; for example, the TPM
code has long assumed that platform driver and device with matching name
could be bound in this way. That assumption may cause such drivers to
fail with Oops during initialization after applying this change. Failure
in suspend/resume tests under qemu has also been reported.

This patch restores the previous (4.3.0 and earlier) behavior of
platform_drv_probe() in the case when the associated platform driver has
no "probe" function.

Fixes: b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are called unconditionally")
Signed-off-by: Martin Wilck <Martin.Wilck@ts.fujitsu.com>
---
 v2: fixed style issues, rephrased commit message.
 v3: rephrased commit message and subject again.

 drivers/base/platform.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 1dd6d3b..176b59f 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -513,10 +513,15 @@ static int platform_drv_probe(struct device *_dev)
 		return ret;
 
 	ret = dev_pm_domain_attach(_dev, true);
-	if (ret != -EPROBE_DEFER && drv->probe) {
-		ret = drv->probe(dev);
-		if (ret)
-			dev_pm_domain_detach(_dev, true);
+	if (ret != -EPROBE_DEFER) {
+		if (drv->probe) {
+			ret = drv->probe(dev);
+			if (ret)
+				dev_pm_domain_detach(_dev, true);
+		} else {
+			/* don't fail if just dev_pm_domain_attach failed */
+			ret = 0;
+		}
 	}
 
 	if (drv->prevent_deferred_probe && ret == -EPROBE_DEFER) {
-- 
1.8.3.1

Thanks,
 Heinz
 

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: Linux 4.5-rc2
  2016-02-01 19:08 ` Heinz Diehl
@ 2016-02-01 20:41   ` Greg KH
  2016-02-01 20:48     ` Linus Torvalds
  2016-02-01 20:46   ` Linus Torvalds
  1 sibling, 1 reply; 9+ messages in thread
From: Greg KH @ 2016-02-01 20:41 UTC (permalink / raw)
  To: Heinz Diehl; +Cc: Linus Torvalds, linux-kernel, stable

On Mon, Feb 01, 2016 at 08:08:01PM +0100, Heinz Diehl wrote:
> Hi,
> 
> On 01.02.2016, Linus Torvalds wrote: 
> 
> > Go forth and test,
> > 
> >                  Linus
> 
> Still, some Asus laptops are hanging at boot-time, both with latest
> -stable and 4.5-rc1/rc2:
> 
> [    4.056862] asus_laptop:    model detected
> [    4.058731] BUG: unable to handle kernel NULL pointer dereference at 0000000000000e20
> [    4.060018] IP: [<ffffffffc03d3423>] asus_sysfs_is_visible+0x13/0x1d0 [asus_laptop]
> [    4.061346] PGD 0
> [    4.062629] Oops: 0000 [#1] PREEMPT SMP
> [    4.063960] Modules linked in: wmi asus_laptop(+) input_polldev sparse_keymap rfkill nfsd auth_rpcgss oid_registry nfs_acl lockd grace sunrpc sch_fq_codel tcp_westwood xfs libcrc32c
> +hid_logitech_dj crc32c_intel serio_raw atl1c i915 i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops drm i2c_core video
> [    4.067026] CPU: 1 PID: 536 Comm: systemd-udevd Not tainted 4.4.0 #1
> [    4.068515] Hardware name: ASUSTeK Computer Inc.         U45JC/U45JC, BIOS U45JC.208 02/24/2011
> [    4.070023] task: ffff88003645b680 ti: ffff8800a4a0c000 task.ti: ffff8800a4a0c000
> [    4.071568] RIP: 0010:[<ffffffffc03d3423>]  [<ffffffffc03d3423>] asus_sysfs_is_visible+0x13/0x1d0 [asus_laptop]
> [    4.073188] RSP: 0000:ffff8800a4a0faf8  EFLAGS: 00010282
> [    4.074820] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
> [    4.076462] RDX: 0000000000000000 RSI: ffffffffc03d63c0 RDI: ffff88003675b420
> [    4.078109] RBP: ffff8800a4a0fb08 R08: ffff8801428940c8 R09: 0000000000000124
> [    4.079777] R10: ffff88014348d100 R11: 0000000000000014 R12: ffffffffc03d4940
> [    4.081470] R13: 0000000000000000 R14: ffff8801418af000 R15: ffffffffc03d6220
> [    4.083156] FS:  00007f58ba6dd8c0(0000) GS:ffff880147c40000(0000) knlGS:0000000000000000
> [    4.084885] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [    4.086611] CR2: 0000000000000e20 CR3: 00000000a49f3000 CR4: 00000000000006e0
> [    4.088351] Stack:
> [    4.090066]  0000000000000000 ffffffffc03d4940 ffff8800a4a0fb50 ffffffff8122d12b
> [    4.091838]  0000000000000000 ffff88003675b420 ffff880141327000 0000000000000000
> [    4.093606]  0000000000000000 ffff880036b42498 0000000000000001 ffff8800a4a0fb60
> [    4.095386] Call Trace:
> [    4.097151]  [<ffffffff8122d12b>] internal_create_group+0xbb/0x310
> [    4.098943]  [<ffffffff8122d393>] sysfs_create_group+0x13/0x20
> [    4.100748]  [<ffffffffc03d292b>] asus_acpi_add+0x3bb/0xea0 [asus_laptop]
> [    4.102583]  [<ffffffff81399d32>] acpi_device_probe+0x4f/0xf5
> [    4.104415]  [<ffffffff81431107>] driver_probe_device+0x167/0x490
> [    4.106254]  [<ffffffff814314b4>] __driver_attach+0x84/0x90
> [    4.108087]  [<ffffffff81431430>] ? driver_probe_device+0x490/0x490
> [    4.109931]  [<ffffffff8142ee34>] bus_for_each_dev+0x64/0xa0
> [    4.111724]  [<ffffffff814309ae>] driver_attach+0x1e/0x20
> [    4.113509]  [<ffffffff8143053b>] bus_add_driver+0x1eb/0x280
> [    4.115273]  [<ffffffffc03da000>] ? 0xffffffffc03da000
> [    4.117032]  [<ffffffff81431d10>] driver_register+0x60/0xe0
> [    4.118818]  [<ffffffff81399c01>] acpi_bus_register_driver+0x38/0x40
> [    4.120619]  [<ffffffffc03da02a>] asus_laptop_init+0x2a/0x1000 [asus_laptop]
> [    4.122433]  [<ffffffff810003db>] do_one_initcall+0xab/0x1c0
> [    4.124276]  [<ffffffff8114b43e>] do_init_module+0x5f/0x1e5
> [    4.126114]  [<ffffffff810d8dff>] load_module+0x1f3f/0x2530
> [    4.127943]  [<ffffffff810d5500>] ? __symbol_put+0x50/0x50
> [    4.129786]  [<ffffffff810d581b>] ? copy_module_from_fd.isra.50+0xdb/0x130
> [    4.131653]  [<ffffffff810d95ea>] SyS_finit_module+0x9a/0xc0
> [    4.133521]  [<ffffffff816bacd7>] entry_SYSCALL_64_fastpath+0x12/0x6a
> [    4.135378] Code: c7 80 48 3d c0 e8 11 7e d7 c0 4c 89 f7 e8 66 3c e5 ff e9 27 ff ff ff 90 66 66 66 66 90 55 48 89 e5 41 54 53 48 8b 8790 00 00 00 <4c> 8b a0 20 0e 00 00 0f b6 80 95 0d 00 00 84 c0 74 1a 48 81 fe
> [    4.139719] RIP  [<ffffffffc03d3423>] asus_sysfs_is_visible+0x13/0x1d0 [asus_laptop]
> [    4.141788]  RSP <ffff8800a4a0faf8>
> [    4.143809] CR2: 0000000000000e20
> [    4.145867] ---[ end trace 7d8d7d572a3e9126 ]---
> 
> The bug is also reported here:
> https://bugzilla.kernel.org/show_bug.cgi?id=110751
> 
> This patch fixes the problem (both for me and others):
> 
> From: Martin Wilck <Martin.Wilck@ts.fujitsu.com>

The patch you show below is included in 4.5-rc2, it's commit
25cad69f21f5532d99e2ee73c8ab6512bcab614c.  So how could you apply it to
4.5-rc2 and have this fix the issue for you?

confused,

greg k-h

> Since b8b2c7d845d5, platform_drv_probe() is called for all platform
> devices. If drv->probe is NULL, and dev_pm_domain_attach() fails,
> platform_drv_probe() will return the error code from dev_pm_domain_attach().
> 
> This causes real_probe() to enter the "probe_failed" path and set
> dev->driver to NULL. Before b8b2c7d845d5, real_probe() would assume
> success if both dev->bus->probe and drv->probe were missing. As a result,
> a device and driver could be "bound" together just by matching their names;
> this doesn't work any more after b8b2c7d845d5.
> 
> This change broke the assumptions of certain drivers; for example, the TPM
> code has long assumed that platform driver and device with matching name
> could be bound in this way. That assumption may cause such drivers to
> fail with Oops during initialization after applying this change. Failure
> in suspend/resume tests under qemu has also been reported.
> 
> This patch restores the previous (4.3.0 and earlier) behavior of
> platform_drv_probe() in the case when the associated platform driver has
> no "probe" function.
> 
> Fixes: b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are called unconditionally")
> Signed-off-by: Martin Wilck <Martin.Wilck@ts.fujitsu.com>
> ---
>  v2: fixed style issues, rephrased commit message.
>  v3: rephrased commit message and subject again.
> 
>  drivers/base/platform.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 1dd6d3b..176b59f 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -513,10 +513,15 @@ static int platform_drv_probe(struct device *_dev)
>  		return ret;
>  
>  	ret = dev_pm_domain_attach(_dev, true);
> -	if (ret != -EPROBE_DEFER && drv->probe) {
> -		ret = drv->probe(dev);
> -		if (ret)
> -			dev_pm_domain_detach(_dev, true);
> +	if (ret != -EPROBE_DEFER) {
> +		if (drv->probe) {
> +			ret = drv->probe(dev);
> +			if (ret)
> +				dev_pm_domain_detach(_dev, true);
> +		} else {
> +			/* don't fail if just dev_pm_domain_attach failed */
> +			ret = 0;
> +		}
>  	}
>  
>  	if (drv->prevent_deferred_probe && ret == -EPROBE_DEFER) {
> -- 
> 1.8.3.1
> 
> Thanks,
>  Heinz
>  
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Linux 4.5-rc2
  2016-02-01 19:08 ` Heinz Diehl
  2016-02-01 20:41   ` Greg KH
@ 2016-02-01 20:46   ` Linus Torvalds
  1 sibling, 0 replies; 9+ messages in thread
From: Linus Torvalds @ 2016-02-01 20:46 UTC (permalink / raw)
  To: Heinz Diehl, Greg Kroah-Hartman; +Cc: Linux Kernel Mailing List, stable

On Mon, Feb 1, 2016 at 11:08 AM, Heinz Diehl <htd+ml@fritha.org> wrote:
>
> Still, some Asus laptops are hanging at boot-time, both with latest
> -stable and 4.5-rc1/rc2:
>
> [    4.056862] asus_laptop:    model detected
> [    4.058731] BUG: unable to handle kernel NULL pointer dereference at 0000000000000e20
> [    4.060018] IP: [<ffffffffc03d3423>] asus_sysfs_is_visible+0x13/0x1d0 [asus_laptop]
>
> The bug is also reported here:
> https://bugzilla.kernel.org/show_bug.cgi?id=110751
>
> This patch fixes the problem (both for me and others):
>
> [ https://patchwork.ozlabs.org/patch/552082/ ]

Greg, do you have that pending, or should I just apply it directly?

                Linus

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Linux 4.5-rc2
  2016-02-01 20:41   ` Greg KH
@ 2016-02-01 20:48     ` Linus Torvalds
  2016-02-01 21:45       ` Heinz Diehl
  0 siblings, 1 reply; 9+ messages in thread
From: Linus Torvalds @ 2016-02-01 20:48 UTC (permalink / raw)
  To: Greg KH; +Cc: Heinz Diehl, Linux Kernel Mailing List, stable

On Mon, Feb 1, 2016 at 12:41 PM, Greg KH <greg@kroah.com> wrote:
>
> The patch you show below is included in 4.5-rc2, it's commit
> 25cad69f21f5532d99e2ee73c8ab6512bcab614c.

Right you are, Greg.

Heinz? Did you actually test rc2 or something else?

                Linus

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Linux 4.5-rc2
  2016-02-01 20:48     ` Linus Torvalds
@ 2016-02-01 21:45       ` Heinz Diehl
  0 siblings, 0 replies; 9+ messages in thread
From: Heinz Diehl @ 2016-02-01 21:45 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Greg KH, Heinz Diehl, Linux Kernel Mailing List, stable

On 01.02.2016, Linus Torvalds wrote: 

> Heinz? Did you actually test rc2 or something else?

You're right, my bad! In fact, I tested 4.4.1-rc1 and 4.5-rc1.
Sorry for the noise!

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-02-01 21:46 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-01  2:28 Linux 4.5-rc2 Linus Torvalds
2016-02-01 13:19 ` Harald Arnesen
2016-02-01 14:18   ` Gerd Hoffmann
2016-02-01 15:19     ` Harald Arnesen
2016-02-01 19:08 ` Heinz Diehl
2016-02-01 20:41   ` Greg KH
2016-02-01 20:48     ` Linus Torvalds
2016-02-01 21:45       ` Heinz Diehl
2016-02-01 20:46   ` Linus Torvalds

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox