From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932528AbcBAUn5 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Feb 2016 15:43:57 -0500
Received: from mga14.intel.com ([192.55.52.115]:29101 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932096AbcBAUn4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Feb 2016 15:43:56 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,381,1449561600"; 
   d="scan'208";a="874366525"
Date: Mon, 1 Feb 2016 15:44:01 -0500
From: Matthew Wilcox <willy@linux.intel.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Use linear_page_index() in do_fault()
Message-ID: <20160201204401.GF2948@linux.intel.com>
References: <1454242401-17005-1-git-send-email-matthew.r.wilcox@intel.com>
 <20160201130638.GB29337@node.shutemov.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160201130638.GB29337@node.shutemov.name>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 01, 2016 at 03:06:38PM +0200, Kirill A. Shutemov wrote:
> On Sun, Jan 31, 2016 at 11:13:21PM +1100, Matthew Wilcox wrote:
> > do_fault assumes that PAGE_SIZE is the same as PAGE_CACHE_SIZE.
> > Use linear_page_index() to calculate pgoff in the correct units.
> > 
> > Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
> 
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> 
> 'linear' part of helper name is not relevant any more since we've dropped
> non-linear mappings. Probably, we should rename helpers.

Ah, that's what it was named for.  Yes, probably.