Re: [PATCH] tty: add Moxa Smartio MUE serial driver

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Feb 01, 2016 at 09:34:19PM +0100, Mathieu OTHACEHE wrote:
> Add a driver which supports:
> 
> - CP-102E: 2 ports RS232 PCIE card
> - CP-102EL: 2 ports RS232 PCIE card
> - CP-132EL: 2 ports RS422/485 PCIE card
> - CP-114EL: 4 ports RS232/422/485 PCIE card
> - CP-104EL-A: 4 ports RS232 PCIE card
> - CP-168EL-A: 8 ports RS232 PCIE card
> - CP-118EL-A: 8 ports RS232/422/485 PCIE card
> - CP-118E-A: 8 ports RS422/485 PCIE card
> - CP-138E-A: 8 ports RS422/485 PCIE card
> - CP-134EL-A: 4 ports RS422/485 PCIE card
> - CP-116E-A (A): 8 ports RS232/422/485 PCIE card
> - CP-116E-A (B): 8 ports RS232/422/485 PCIE card
> 
> This driver is based on 1.16.7 GPL MOXA driver written by Eric Lo
> and available on MOXA website. The original driver was based on
> Linux serial driver.
> 
> Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>
> ---
> 
> Hi,
> 
> Here is a new driver for MOXA Smartio MUE cards. It is based
> on the vendor driver available on MOXA website and on the
> mainline mxser driver.
> 
> I was able to test it on a CP-168EL-A card on PC. Some of the
> cards (118E-A, 138E-A, 134EL-A, 116E-A-A et 116E-A-B) have
> a CPLD module programmable via GPIO.
> For now, I dropped all the code related to CPLD/GPIO because I
> can't test it on my card.
> 
> Mathieu
> 
>  MAINTAINERS           |    5 +
>  drivers/tty/Kconfig   |   10 +
>  drivers/tty/Makefile  |    1 +
>  drivers/tty/mxupcie.c | 1874 +++++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/tty/mxupcie.h |  129 ++++

Minor nit, but why do you need a .h file here when no one else includes
it?  Why not just put it into the .c file to keep things nice and
self-contained?

thanks,

greg k-h