From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753465AbcBBGx3 (ORCPT ); Tue, 2 Feb 2016 01:53:29 -0500 Received: from mail.kernel.org ([198.145.29.136]:55931 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752715AbcBBGx2 (ORCPT ); Tue, 2 Feb 2016 01:53:28 -0500 Date: Tue, 2 Feb 2016 14:53:07 +0800 From: Shawn Guo To: Lothar =?iso-8859-1?Q?Wa=DFmann?= Cc: Ian Campbell , Kumar Gala , Mark Rutland , Pawel Moll , Rob Herring , Russell King , Sascha Hauer , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] ARM: dts: imx53: add ethernet PHY supply regulator Message-ID: <20160202065306.GH8307@tiger> References: <1453295362-18798-1-git-send-email-LW@KARO-electronics.de> <1453295362-18798-2-git-send-email-LW@KARO-electronics.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1453295362-18798-2-git-send-email-LW@KARO-electronics.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2016 at 02:09:19PM +0100, Lothar Waßmann wrote: > Signed-off-by: Lothar Waßmann > --- > arch/arm/boot/dts/imx53-tx53.dtsi | 40 ++++++++++++++++++++++++++++++--------- > 1 file changed, 31 insertions(+), 9 deletions(-) > > diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi > index d3e50b2..8f08389 100644 > --- a/arch/arm/boot/dts/imx53-tx53.dtsi > +++ b/arch/arm/boot/dts/imx53-tx53.dtsi > @@ -87,9 +87,20 @@ > regulator-max-microvolt = <3300000>; > }; > > - reg_can_xcvr: regulator@2 { > + reg_3v3_etn: regulator@2 { Why cannot this be added as regulator@5 to avoid changing every node? > compatible = "regulator-fixed"; > reg = <2>; > + regulator-name = "ETN 3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_etn_phy>; > + gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>; > + }; > + > + reg_can_xcvr: regulator@3 { > + compatible = "regulator-fixed"; > + reg = <3>; > regulator-name = "CAN XCVR"; > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > @@ -98,9 +109,9 @@ > gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>; > }; > > - reg_usbh1_vbus: regulator@3 { > + reg_usbh1_vbus: regulator@4 { > compatible = "regulator-fixed"; > - reg = <3>; > + reg = <4>; > regulator-name = "usbh1_vbus"; > regulator-min-microvolt = <5000000>; > regulator-max-microvolt = <5000000>; > @@ -110,9 +121,9 @@ > enable-active-high; > }; > > - reg_usbotg_vbus: regulator@4 { > + reg_usbotg_vbus: regulator@5 { > compatible = "regulator-fixed"; > - reg = <4>; > + reg = <5>; > regulator-name = "usbotg_vbus"; > regulator-min-microvolt = <5000000>; > regulator-max-microvolt = <5000000>; > @@ -204,13 +215,20 @@ > phy-mode = "rmii"; > phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_HIGH>; > phy-handle = <&phy0>; > + phy-supply = <®_3v3_etn>; > mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */ > status = "okay"; > > - phy0: ethernet-phy@0 { > - interrupt-parent = <&gpio2>; > - interrupts = <4>; > - device_type = "ethernet-phy"; > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + phy0: ethernet-phy@0 { > + compatible = "ethernet-phy-id0007.c0f1", "ethernet-phy-ieee802.3-c22"; > + reg = <0>; > + interrupt-parent = <&gpio2>; > + interrupts = <4>; > + }; This should be a separate change. Shawn > }; > }; > > @@ -309,6 +327,10 @@ > fsl,pins = ; /* Flexcan XCVR enable */ > }; > > + pinctrl_etn_phy: etn-phygrp { > + fsl,pins = ; /* ETN PHY Power enable */ > + }; > + > pinctrl_ds1339: ds1339grp { > fsl,pins = ; > }; > -- > 2.1.4 > >