From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754837AbcBBLPv (ORCPT ); Tue, 2 Feb 2016 06:15:51 -0500 Received: from mail.skyhub.de ([78.46.96.112]:52262 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754442AbcBBLPs (ORCPT ); Tue, 2 Feb 2016 06:15:48 -0500 Date: Tue, 2 Feb 2016 12:15:45 +0100 From: Borislav Petkov To: Sudip Mukherjee Cc: Johannes Thumshirn , Doug Thompson , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org Subject: Re: [PATCH] EDAC, mpc85xx: fix build warning Message-ID: <20160202111545.GC3778@pd.tnic> References: <1454400021-17583-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1454400021-17583-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2016 at 01:30:21PM +0530, Sudip Mukherjee wrote: > We were getting build warning about: > drivers/edac/mpc85xx_edac.c:1247:6: warning: unused variable 'pvr' > > pvr is only used if CONFIG_FSL_SOC_BOOKE was defined. Declare the > variable as a local variable inside the #ifdef block. What's wrong with doing the simpler thing: --- diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c index b7139c160baf..f756b6215228 100644 --- a/drivers/edac/mpc85xx_edac.c +++ b/drivers/edac/mpc85xx_edac.c @@ -1244,7 +1244,6 @@ static struct platform_driver * const drivers[] = { static int __init mpc85xx_mc_init(void) { int res = 0; - u32 pvr = 0; printk(KERN_INFO "Freescale(R) MPC85xx EDAC driver, " "(C) 2006 Montavista Software\n"); @@ -1264,10 +1263,8 @@ static int __init mpc85xx_mc_init(void) printk(KERN_WARNING EDAC_MOD_STR "drivers fail to register\n"); #ifdef CONFIG_FSL_SOC_BOOKE - pvr = mfspr(SPRN_PVR); - - if ((PVR_VER(pvr) == PVR_VER_E500V1) || - (PVR_VER(pvr) == PVR_VER_E500V2)) { + if ((PVR_VER(mfspr(SPRN_PVR)) == PVR_VER_E500V1) || + (PVR_VER(mfspr(SPRN_PVR)) == PVR_VER_E500V2)) { /* * need to clear HID1[RFXE] to disable machine check int * so we can catch it --- Granted, we get MFSPR issued twice by the compiler but that's the init path. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.