From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755332AbcBBO2J (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Feb 2016 09:28:09 -0500
Received: from mga01.intel.com ([192.55.52.88]:55607 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755253AbcBBO2F (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Feb 2016 09:28:05 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,385,1449561600"; 
   d="scan'208";a="739128518"
Date: Tue, 2 Feb 2016 14:27:57 +0000
From: Keith Busch <keith.busch@intel.com>
To: Sagi Grimberg <sagig@dev.mellanox.co.il>
Cc: Wenbo Wang <wenbo.wang@memblaze.com>, Jens Axboe <axboe@fb.com>,
        Wenbo Wang <mail_weber_wang@163.com>,
        "Wenwei.Tao" <wenwei.tao@memblaze.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] NVMe: do not touch sq door bell if nvmeq has been
 suspended
Message-ID: <20160202142756.GA10690@localhost.localdomain>
References: <1454341324-21273-1-git-send-email-mail_weber_wang@163.com>
 <56AF8DB5.70206@fb.com>
 <BJXPR01MB19940BA759DBBADC6BF6BD2E0DF0@BJXPR01MB199.CHNPR01.prod.partner.outlook.cn>
 <56B0A401.30306@dev.mellanox.co.il>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56B0A401.30306@dev.mellanox.co.il>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 02, 2016 at 02:41:37PM +0200, Sagi Grimberg wrote:
> First of all, I think we need to cancel all
> inflight requests before nvme_dev_unmap.

IO cancelling is where it is because it protects against host memory
corruption. If you're going to mess with the ordering, just make sure
the PCI device is disabled from bus mastering first.