From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755456AbcBBOfJ (ORCPT ); Tue, 2 Feb 2016 09:35:09 -0500 Received: from mx2.parallels.com ([199.115.105.18]:60596 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755197AbcBBOfG (ORCPT ); Tue, 2 Feb 2016 09:35:06 -0500 Date: Tue, 2 Feb 2016 17:34:54 +0300 From: Vladimir Davydov To: Johannes Weiner CC: Andrew Morton , Michal Hocko , , , , Subject: Re: [PATCH v2 5/5] mm: workingset: per-cgroup cache thrash detection Message-ID: <20160202143454.GC21016@esperanza> References: <1454090047-1790-1-git-send-email-hannes@cmpxchg.org> <1454090047-1790-6-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1454090047-1790-6-git-send-email-hannes@cmpxchg.org> X-ClientProxiedBy: US-EXCH.sw.swsoft.com (10.255.249.47) To US-EXCH.sw.swsoft.com (10.255.249.47) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 29, 2016 at 12:54:07PM -0500, Johannes Weiner wrote: > Cache thrash detection (see a528910e12ec "mm: thrash detection-based > file cache sizing" for details) currently only works on the system > level, not inside cgroups. Worse, as the refaults are compared to the > global number of active cache, cgroups might wrongfully get all their > refaults activated when their pages are hotter than those of others. > > Move the refault machinery from the zone to the lruvec, and then tag > eviction entries with the memcg ID. This makes the thrash detection > work correctly inside cgroups. > > Signed-off-by: Johannes Weiner Reviewed-by: Vladimir Davydov