From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755438AbcBBOiH (ORCPT ); Tue, 2 Feb 2016 09:38:07 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:53061 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754290AbcBBOiF (ORCPT ); Tue, 2 Feb 2016 09:38:05 -0500 Date: Tue, 2 Feb 2016 06:38:01 -0800 From: Guenter Roeck To: Borislav Petkov Cc: Sudip Mukherjee , Johannes Thumshirn , Doug Thompson , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org Subject: Re: [PATCH] EDAC, mpc85xx: fix build warning Message-ID: <20160202143801.GA6995@roeck-us.net> References: <1454400021-17583-1-git-send-email-sudipm.mukherjee@gmail.com> <20160202111545.GC3778@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160202111545.GC3778@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2016 at 12:15:45PM +0100, Borislav Petkov wrote: > On Tue, Feb 02, 2016 at 01:30:21PM +0530, Sudip Mukherjee wrote: > > We were getting build warning about: > > drivers/edac/mpc85xx_edac.c:1247:6: warning: unused variable 'pvr' > > > > pvr is only used if CONFIG_FSL_SOC_BOOKE was defined. Declare the > > variable as a local variable inside the #ifdef block. > > What's wrong with doing the simpler thing: > > --- > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c > index b7139c160baf..f756b6215228 100644 > --- a/drivers/edac/mpc85xx_edac.c > +++ b/drivers/edac/mpc85xx_edac.c > @@ -1244,7 +1244,6 @@ static struct platform_driver * const drivers[] = { > static int __init mpc85xx_mc_init(void) > { > int res = 0; > - u32 pvr = 0; > Or with just adding __maybe_unused here. Guenter > printk(KERN_INFO "Freescale(R) MPC85xx EDAC driver, " > "(C) 2006 Montavista Software\n"); > @@ -1264,10 +1263,8 @@ static int __init mpc85xx_mc_init(void) > printk(KERN_WARNING EDAC_MOD_STR "drivers fail to register\n"); > > #ifdef CONFIG_FSL_SOC_BOOKE > - pvr = mfspr(SPRN_PVR); > - > - if ((PVR_VER(pvr) == PVR_VER_E500V1) || > - (PVR_VER(pvr) == PVR_VER_E500V2)) { > + if ((PVR_VER(mfspr(SPRN_PVR)) == PVR_VER_E500V1) || > + (PVR_VER(mfspr(SPRN_PVR)) == PVR_VER_E500V2)) { > /* > * need to clear HID1[RFXE] to disable machine check int > * so we can catch it > --- > > Granted, we get MFSPR issued twice by the compiler but that's the init > path. > > -- > Regards/Gruss, > Boris. > > ECO tip #101: Trim your mails when you reply. > >