From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932913AbcBBPJy (ORCPT ); Tue, 2 Feb 2016 10:09:54 -0500 Received: from mail.skyhub.de ([78.46.96.112]:57587 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932451AbcBBPJx (ORCPT ); Tue, 2 Feb 2016 10:09:53 -0500 Date: Tue, 2 Feb 2016 16:09:50 +0100 From: Borislav Petkov To: Sudip Mukherjee Cc: Johannes Thumshirn , Guenter Roeck , Johannes Thumshirn , Doug Thompson , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org Subject: Re: [PATCH] EDAC, mpc85xx: fix build warning Message-ID: <20160202150950.GC15507@pd.tnic> References: <1454400021-17583-1-git-send-email-sudipm.mukherjee@gmail.com> <20160202111545.GC3778@pd.tnic> <20160202143801.GA6995@roeck-us.net> <20160202144803.GQ27969@c203.arch.suse.de> <20160202145554.GB7200@sudip-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160202145554.GB7200@sudip-laptop> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2016 at 08:25:54PM +0530, Sudip Mukherjee wrote: > oops... i just sent the v2 while removing pvr. Which is the better way > then? > Personally, I donot like __maybe_unused, it is telling gcc that this > variable is unused so donot give any warning for it. But in reality it > is being used in some cases. And? You want to shut up the warning, right? Adding __maybe_unused is the simplest variant without disadvantages. Or are there any? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.