From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
Guenter Roeck <linux@roeck-us.net>,
Johannes Thumshirn <morbidrsa@gmail.com>,
Doug Thompson <dougthompson@xmission.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH] EDAC, mpc85xx: fix build warning
Date: Tue, 2 Feb 2016 20:43:57 +0530 [thread overview]
Message-ID: <20160202151357.GC7200@sudip-laptop> (raw)
In-Reply-To: <20160202150950.GC15507@pd.tnic>
On Tue, Feb 02, 2016 at 04:09:50PM +0100, Borislav Petkov wrote:
> On Tue, Feb 02, 2016 at 08:25:54PM +0530, Sudip Mukherjee wrote:
> > oops... i just sent the v2 while removing pvr. Which is the better way
> > then?
> > Personally, I donot like __maybe_unused, it is telling gcc that this
> > variable is unused so donot give any warning for it. But in reality it
> > is being used in some cases.
>
> And? You want to shut up the warning, right?
>
> Adding __maybe_unused is the simplest variant without disadvantages. Or
> are there any?
another way might be:
diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index b7139c1..968c0c0 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -1244,7 +1244,9 @@ static struct platform_driver * const drivers[] = {
static int __init mpc85xx_mc_init(void)
{
int res = 0;
+#ifdef CONFIG_FSL_SOC_BOOKE
u32 pvr = 0;
+#endif
printk(KERN_INFO "Freescale(R) MPC85xx EDAC driver, "
"(C) 2006 Montavista Software\n");
regards
sudip
next prev parent reply other threads:[~2016-02-02 15:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 8:00 [PATCH] EDAC, mpc85xx: fix build warning Sudip Mukherjee
2016-02-02 11:15 ` Borislav Petkov
2016-02-02 14:38 ` Guenter Roeck
2016-02-02 14:48 ` Johannes Thumshirn
2016-02-02 14:55 ` Sudip Mukherjee
2016-02-02 15:09 ` Borislav Petkov
2016-02-02 15:13 ` Sudip Mukherjee [this message]
2016-02-02 15:15 ` Borislav Petkov
2016-02-02 15:19 ` Sudip Mukherjee
2016-02-02 14:48 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202151357.GC7200@sudip-laptop \
--to=sudipm.mukherjee@gmail.com \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=jthumshirn@suse.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab@osg.samsung.com \
--cc=morbidrsa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox