From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933057AbcBBPPr (ORCPT ); Tue, 2 Feb 2016 10:15:47 -0500 Received: from mail.skyhub.de ([78.46.96.112]:55470 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932939AbcBBPPq (ORCPT ); Tue, 2 Feb 2016 10:15:46 -0500 Date: Tue, 2 Feb 2016 16:15:43 +0100 From: Borislav Petkov To: Sudip Mukherjee Cc: Johannes Thumshirn , Guenter Roeck , Johannes Thumshirn , Doug Thompson , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org Subject: Re: [PATCH] EDAC, mpc85xx: fix build warning Message-ID: <20160202151543.GD15507@pd.tnic> References: <1454400021-17583-1-git-send-email-sudipm.mukherjee@gmail.com> <20160202111545.GC3778@pd.tnic> <20160202143801.GA6995@roeck-us.net> <20160202144803.GQ27969@c203.arch.suse.de> <20160202145554.GB7200@sudip-laptop> <20160202150950.GC15507@pd.tnic> <20160202151357.GC7200@sudip-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160202151357.GC7200@sudip-laptop> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2016 at 08:43:57PM +0530, Sudip Mukherjee wrote: > another way might be: > > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c > index b7139c1..968c0c0 100644 > --- a/drivers/edac/mpc85xx_edac.c > +++ b/drivers/edac/mpc85xx_edac.c > @@ -1244,7 +1244,9 @@ static struct platform_driver * const drivers[] = { > static int __init mpc85xx_mc_init(void) > { > int res = 0; > +#ifdef CONFIG_FSL_SOC_BOOKE > u32 pvr = 0; > +#endif Nah, this is the ugliest of them all. We want less ifdeffery, not more. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.