From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756808AbcBBRjd (ORCPT ); Tue, 2 Feb 2016 12:39:33 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:57536 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756702AbcBBRj3 (ORCPT ); Tue, 2 Feb 2016 12:39:29 -0500 Date: Tue, 2 Feb 2016 09:39:27 -0800 From: Darren Hart To: Mario Limonciello Cc: LKML , platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v2 0/5] alienware-wmi new platform and feature support Message-ID: <20160202173927.GE1779@malice.jf.intel.com> References: <1454380131-24662-1-git-send-email-mario_limonciello@dell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454380131-24662-1-git-send-email-mario_limonciello@dell.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2016 at 08:28:46PM -0600, Mario Limonciello wrote: > I've got some extensions for the alienware-wmi driver that have > been introduced for a few new platforms and can be controlled via the WMI > interface. > > Changes from V1: > - Make sure whitespace changes are in their own patch > - Add commit descriptions to all patches > - Allow one line to go over 80 characters in deep sleep control patch > Other patches may have some areas that avoid going over 80 characters > still, but this matches the style of the existing driver. If you would > like these to go over 80 characters as well, please comment which areas > this is OK. This made it much easier to review. Thank you Mario. A few changes requested, and a couple questions for you regarding intent/best-practice. Thanks! -- Darren Hart Intel Open Source Technology Center