From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933490AbcBBS3W (ORCPT ); Tue, 2 Feb 2016 13:29:22 -0500 Received: from foss.arm.com ([217.140.101.70]:57816 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932847AbcBBS3M (ORCPT ); Tue, 2 Feb 2016 13:29:12 -0500 Date: Tue, 2 Feb 2016 18:28:42 +0000 From: Mark Rutland To: Gregory CLEMENT Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , arm@kernel.org, Catalin Marinas , Will Deacon , Jonathan Corbet , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, Tejun Heo , Hans de Goede , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Wilson Ding , Nadav Haklai Subject: Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Message-ID: <20160202182842.GD29778@leverpostej> References: <1454436468-4241-1-git-send-email-gregory.clement@free-electrons.com> <1454436468-4241-2-git-send-email-gregory.clement@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454436468-4241-2-git-send-email-gregory.clement@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2016 at 07:07:39PM +0100, Gregory CLEMENT wrote: > From: Wilson Ding > > Armada-3700's uart is a simple serial port, which doesn't > support. Configuring the modem control lines. The uart port has a 32 > bytes Tx FIFO and a 64 bytes Rx FIFO > > The uart driver implements the uart core operations. It also support the > system (early) console based on Armada-3700's serial port. > > Known Issue: > > The uart driver currently doesn't support clock programming, which means > the baud-rate stays with the default value configured by the bootloader > at boot time To ensure that the bootloader and kernel match, it's best to place the rate in the stdout-path property (as in Documentation/devicetree/bindings/chosen.txt). Presumably that is what you want? Is it difficutl to add clock programming? > > [gregory.clement@free-electrons.com: Rewrite many part which are too long > to enumerate] > > Signed-off-by: Wilson Ding > Signed-off-by: Nadav Haklai > Signed-off-by: Gregory CLEMENT > --- > .../devicetree/bindings/tty/serial/mvebu-uart.txt | 13 + > Documentation/kernel-parameters.txt | 6 + > drivers/tty/serial/Kconfig | 22 + > drivers/tty/serial/Makefile | 1 + > drivers/tty/serial/mvebu-uart.c | 649 +++++++++++++++++++++ > include/uapi/linux/serial_core.h | 3 + > 6 files changed, 694 insertions(+) > create mode 100644 Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt > create mode 100644 drivers/tty/serial/mvebu-uart.c > > diff --git a/Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt b/Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt > new file mode 100644 > index 000000000000..6087defd9f93 > --- /dev/null > +++ b/Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt > @@ -0,0 +1,13 @@ > +* Marvell UART : Non standard UART used in some of Marvell EBU SoCs (e.g., Armada-3700) > + > +Required properties: > +- compatible: "marvell,armada-3700-uart" > +- reg: offset and length of the register set for the device. > +- interrupts: device interrupt > + > +Example: > + serial@12000 { > + compatible = "marvell,armada-3700-uart"; > + reg = <0x12000 0x400>; > + interrupts = <43>; > + }; There are no external clock inputs? > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt > index 87d40a72f6a1..198f6bd56e84 100644 > --- a/Documentation/kernel-parameters.txt > +++ b/Documentation/kernel-parameters.txt > @@ -1058,6 +1058,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted. > A valid base address must be provided, and the serial > port must already be setup and configured. > > + mvebu_uart, > + Start an early, polled-mode console on an some mvebu > + SoC (as the Armada-3700) serial port at the specified > + address. The serial port must already be setup and > + configured. Options are not yet supported. > + Does the the mvebu UART vary between platforms at all? Thanks, Mark.