From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755061AbcBBLoS (ORCPT ); Tue, 2 Feb 2016 06:44:18 -0500 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:13838 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754630AbcBBLoQ (ORCPT ); Tue, 2 Feb 2016 06:44:16 -0500 Date: Tue, 2 Feb 2016 19:39:42 +0800 From: Jisheng Zhang To: Ulf Hansson CC: Ludovic Desroches , linux-mmc , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] mmc: sdhci-of-at91: fix pm runtime unbalanced issue in error path Message-ID: <20160202193942.3525cd5d@xhacker> In-Reply-To: References: <1453804954-3490-1-git-send-email-jszhang@marvell.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-02-02_08:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1602020199 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Feb 2016 12:32:29 +0100 Ulf Hansson wrote: > On 26 January 2016 at 11:42, Jisheng Zhang wrote: > > The device power usage counter is increased by pm_runtime_get_noresume > > but isn't decreased in err_add_host error path. > > > > Fix this issue by calling pm_runtime_put_noidle() in the error path to > > restore the device's power usage counter. > > > > Signed-off-by: Jisheng Zhang > > Fixes: f5f17813ae9b ("mmc: sdhci-of-at91: add PM support) > > --- > > drivers/mmc/host/sdhci-of-at91.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c > > index 7db7163..3bf6f31 100644 > > --- a/drivers/mmc/host/sdhci-of-at91.c > > +++ b/drivers/mmc/host/sdhci-of-at91.c > > @@ -210,7 +210,7 @@ static int sdhci_at91_probe(struct platform_device *pdev) > > > > pm_runtime_disable: > > pm_runtime_disable(&pdev->dev); > > - pm_runtime_set_suspended(&pdev->dev); > > What's the reason you want to remove the call to > pm_runtime_set_suspended()? I think it could stay. Indeed, thanks for pointing out. Will send a v2. Thank you, Jisheng > > > + pm_runtime_put_noidle(&pdev->dev); > > clocks_disable_unprepare: > > clk_disable_unprepare(priv->gck); > > clk_disable_unprepare(priv->mainck); > > -- > > 2.7.0 > > > > Kind regards > Uffe