From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965326AbcBBVTJ (ORCPT ); Tue, 2 Feb 2016 16:19:09 -0500 Received: from mail.kernel.org ([198.145.29.136]:35106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964891AbcBBVTH (ORCPT ); Tue, 2 Feb 2016 16:19:07 -0500 Date: Tue, 2 Feb 2016 18:19:03 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Namhyung Kim , Jiri Olsa , lkml , David Ahern , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH 14/26] perf tools: Introduce struct perf_hpp_list Message-ID: <20160202211903.GI32488@kernel.org> References: <1453109064-1026-1-git-send-email-jolsa@kernel.org> <1453109064-1026-15-git-send-email-jolsa@kernel.org> <20160125150046.GB7794@danjae.kornet> <20160125150933.GA3251@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160125150933.GA3251@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jan 25, 2016 at 04:09:33PM +0100, Jiri Olsa escreveu: > On Tue, Jan 26, 2016 at 12:00:46AM +0900, Namhyung Kim wrote: > > SNIP > > > > void perf_hpp__cancel_cumulate(void) > > > diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h > > > index f3bcf2d38733..a9c8ccfcc284 100644 > > > --- a/tools/perf/util/hist.h > > > +++ b/tools/perf/util/hist.h > > > @@ -226,20 +226,24 @@ struct perf_hpp_fmt { > > > int idx; > > > }; > > > > > > -extern struct list_head perf_hpp__list; > > > -extern struct list_head perf_hpp__sort_list; > > > +struct perf_hpp_list { > > > + struct list_head list; > > > + struct list_head sort_list; > > > +}; > > > > What about this? > > > > struct perf_hpp_list { > > struct list_head fields; > > struct list_head sorts; > > }; > > > > This also aligns with the option names. > > yep, sounds better ;-) Ok, did the change as I'm refreshing this series to merge it. - Arnaldo