From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933835AbcBCHsm (ORCPT ); Wed, 3 Feb 2016 02:48:42 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35117 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933379AbcBCHsj (ORCPT ); Wed, 3 Feb 2016 02:48:39 -0500 Date: Wed, 3 Feb 2016 08:48:35 +0100 From: Ingo Molnar To: akpm@linux-foundation.org Cc: hpa@zytor.com, mingo@elte.hu, tglx@linutronix.de, willy@linux.intel.com, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: + x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes.patch added to -mm tree Message-ID: <20160203074835.GB32652@gmail.com> References: <56b13381.v0wS03ZQEKxwivVW%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56b13381.v0wS03ZQEKxwivVW%akpm@linux-foundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * akpm@linux-foundation.org wrote: > diff -puN arch/x86/include/asm/pgtable_64.h~x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes arch/x86/include/asm/pgtable_64.h > --- a/arch/x86/include/asm/pgtable_64.h~x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes > +++ a/arch/x86/include/asm/pgtable_64.h > @@ -111,8 +111,10 @@ static inline pud_t native_pudp_get_and_ > #ifdef CONFIG_SMP > return native_make_pud(xchg(&pudp->pud, 0)); > #else > - /* native_local_pudp_get_and_clear, > - but duplicated because of cyclic dependency */ > + /* > + * native_local_pudp_get_and_clear, but duplicated because of cyclic > + * dependency > + */ > pud_t ret = *pudp; > native_pud_clear(pudp); > return ret; When referring to functions in comments (or changelogs) please use () to make it clear on sight what is being referred to. Also, please try to construct proper English sentences with verbs and such! I.e. something like this would work for me: > + /* > + * This is a duplicate of native_local_pudp_get_and_clear(), > + * because we cannot use the original due to a cyclic header > + * file dependency: > + */ (Assuming I managed to decode the shorthand form properly.) Thanks, Ingo