From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933848AbcBCI1K (ORCPT ); Wed, 3 Feb 2016 03:27:10 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:36845 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933495AbcBCI1E (ORCPT ); Wed, 3 Feb 2016 03:27:04 -0500 Date: Wed, 3 Feb 2016 13:57:00 +0530 From: Viresh Kumar To: Shilpasri G Bhat Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, rjw@rjwysocki.net, linux-pm@vger.kernel.org, pc@us.ibm.com, anton@samba.org, ego@linux.vnet.ibm.com, shreyas@linux.vnet.ibm.com, bsingharora@gmail.com, mpe@ellerman.id.au, linux-api@vger.kernel.org Subject: Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Message-ID: <20160203082700.GZ31828@vireshk> References: <1454442102-1229-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> <1454442102-1229-7-git-send-email-shilpa.bhat@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454442102-1229-7-git-send-email-shilpa.bhat@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03-02-16, 01:11, Shilpasri G Bhat wrote: > static int init_chip_info(void) > { > unsigned int chip[256]; > - unsigned int cpu, i; > + unsigned int cpu; > unsigned int prev_chip_id = UINT_MAX; > cpumask_t cpu_mask; > - int ret = -ENOMEM; > + int i, j, ret = -ENOMEM; > > core_to_chip_map = kcalloc(cpu_nr_cores(), sizeof(unsigned int), > GFP_KERNEL); > @@ -583,12 +711,51 @@ static int init_chip_info(void) > goto free_chip_map; > > for (i = 0; i < nr_chips; i++) { > + char name[10]; > + > chips[i].id = chip[i]; > cpumask_copy(&chips[i].mask, cpumask_of_node(chip[i])); > INIT_WORK(&chips[i].throttle, powernv_cpufreq_work_fn); > + > + for (j = 0; j <= OCC_MAX_THROTTLE_STATUS; j++) { > + chips[i].reason[j] = > + kcalloc(powernv_pstate_info.nr_pstates, > + sizeof(int), GFP_KERNEL); > + if (!chips[i].reason[j]) { > + ret = -ENOMEM; > + goto free_chip; > + } > + } > + > + snprintf(name, sizeof(name), "chip%d", chips[i].id); > + ret = kobject_init_and_add(&chips[i].kobj, > + get_ktype(cpufreq_global_kobject), Sorry but why do you need to create a kobject here ? A simple sysfs_create_group() can create groups (directories) for you. > + cpufreq_global_kobject, name); > + if (ret) > + goto free_chip; > + > + ret = sysfs_create_group(&chips[i].kobj, &throttle_stat_group); > + if (ret) { > + pr_info("Chip %d failed to create throttle sysfs group\n", > + chips[i].id); > + goto free_kobject; > + } > } -- viresh