From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754885AbcBCKMT (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Feb 2016 05:12:19 -0500
Received: from mail-wm0-f67.google.com ([74.125.82.67]:32769 "EHLO
	mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751944AbcBCKMN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Feb 2016 05:12:13 -0500
Date: Wed, 3 Feb 2016 11:12:09 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Juri Lelli <juri.lelli@gmail.com>,
        Clark Williams <williams@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to
 show current bandwidths
Message-ID: <20160203101209.GA5746@gmail.com>
References: <20160201202624.079532484@goodmis.org>
 <20160201202742.317361821@goodmis.org>
 <20160201221720.GZ6357@twins.programming.kicks-ass.net>
 <20160201173809.3df5c1f3@gandalf.local.home>
 <20160201224130.GB6357@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160201224130.GB6357@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Mon, Feb 01, 2016 at 05:38:09PM -0500, Steven Rostedt wrote:
> 
> > Regardless of this final patch, what do you think of the first three? I
> > can send them as a separate series, just to get more of the SCHED_DEBUG
> > code into debug.c.
> 
> The first two looked ok, the third I had a vague niggle it might be part
> of something bigger and tearing it up like this might make it harder.

Yeah, so the purpose of kernel/sched/debug.c is mostly meant as a filesystem 
interface to display various internal scheduler details. It mostly deals with 
/proc/sched_debug details: hence the name.

Note that 'sched domain debugging' does not fit into that cleanly, because it also 
does sanity checking of the sched-domains data. So I'm not sure we want to do 
patch #3 that moves sched-domain debugging to debug.c.

So debug.c is named in a bit too generic fashion, attracting such patches.

Thanks,

	Ingo