From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754383AbcBCKdA (ORCPT ); Wed, 3 Feb 2016 05:33:00 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:46484 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752192AbcBCKc6 (ORCPT ); Wed, 3 Feb 2016 05:32:58 -0500 Date: Wed, 3 Feb 2016 10:32:55 +0000 From: Paul Burton To: Sergei Shtylyov CC: , Ralf Baechle , "Andrey Konovalov" , Andrey Ryabinin , , Andrew Morton Subject: Re: [PATCH 4/5] MIPS: Support R_MIPS_PC16 rel-style reloc Message-ID: <20160203103255.GA21157@NP-P-BURTON> References: <1454471085-20963-1-git-send-email-paul.burton@imgtec.com> <1454471085-20963-5-git-send-email-paul.burton@imgtec.com> <56B1D5B5.6050208@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <56B1D5B5.6050208@cogentembedded.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [10.100.200.105] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 03, 2016 at 01:25:57PM +0300, Sergei Shtylyov wrote: > Hello. > > On 2/3/2016 6:44 AM, Paul Burton wrote: > >MIPS32 code uses rel-style relocs, and MIPS32r6 modules may include the > >R_MIPS_PC16 relocation. We thus need to support R_MIPS_PC16 rel-style > >relocations in order to load MIPS32r6 kernel modules. This patch adds > >such support, which is similar to the rela-style R_MIPS_PC16 support but > > R_MIPS_LO16, you mean? Hi Sergei, No, I mean it's similar to the R_MIPS_PC16 code in module-rela.c. That is, its rela-style equivalent (rather than rel-style as here). Thanks, Paul