* Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver
[not found] ` <BLU185-W57359ACFC388D47D82082680DF0@phx.gbl>
@ 2016-02-03 13:24 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-02-03 13:24 UTC (permalink / raw)
To: Bijosh Thykkoottathil
Cc: gregkh@linuxfoundation.org, christian.gromm@microchip.com,
devel@driverdev.osuosl.org, adrianremonda@gmail.com,
chris@engineersdelight.de, linux-kernel@vger.kernel.org,
Michael.Fabry@microchip.com, sudipm.mukherjee@gmail.com,
andrey.shvetsov@k2l.de
On Tue, Feb 02, 2016 at 06:57:46AM +0530, Bijosh Thykkoottathil wrote:
> Gentle reminder.
Wait for two more weeks before reminding us.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver
[not found] <BLU437-SMTP51F1BD523F77BFB1E1B51480DB0@phx.gbl>
[not found] ` <BLU185-W57359ACFC388D47D82082680DF0@phx.gbl>
@ 2016-02-07 22:18 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-02-07 22:18 UTC (permalink / raw)
To: Bijosh Thykkoottathil
Cc: devel, adrianremonda, linux-kernel, christian.gromm,
sudipm.mukherjee, andrey.shvetsov
On Fri, Jan 29, 2016 at 11:33:20PM +0530, Bijosh Thykkoottathil wrote:
> Fixes following coding style issues reported by the check patch script.
> - ERROR: Macros with complex values should be enclosed in parentheses
>
> Moving static storage class to the beginning of declaration fixes these
> errors.
Well that's a horrid fix for this, as you aren't doing anything
different here.
Fix the tool if it is reporting things incorrectly, don't blindly change
code for no reason please. checkpatch isn't always correct, as you have
found out.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <BLU436-SMTP23BDE7B8746553D1EA0FFD80DB0@phx.gbl>]
* Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver
[not found] <BLU436-SMTP23BDE7B8746553D1EA0FFD80DB0@phx.gbl>
@ 2016-01-29 17:32 ` Sudip Mukherjee
0 siblings, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2016-01-29 17:32 UTC (permalink / raw)
To: Bijosh Thykkoottathil
Cc: gregkh, christian.gromm, andrey.shvetsov, adrianremonda, devel,
linux-kernel
On Fri, Jan 29, 2016 at 10:38:42PM +0530, Bijosh Thykkoottathil wrote:
> From: Bijosh Thykkoottathil <bijosh.t@hotmail.com>
You do not need this From: line here. The email From: header is
sufficient.
>
> Fixes following coading style issues reported by the check patch script.
> - ERROR: Macros with complex values should be enclosed in parentheses
> - CHECK: struct mutex definition without comment
> - CHECK: spinlock_t definition without comment
> - CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code
> rather than BUG() or BUG_ON()
> - WARNING: storage class should be at the beginning of the declaration
You are doing too many things in one patch. Please break them up into
separate patches. Each patch should do only one type of change.
regards
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-07 22:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <BLU437-SMTP51F1BD523F77BFB1E1B51480DB0@phx.gbl>
[not found] ` <BLU185-W57359ACFC388D47D82082680DF0@phx.gbl>
2016-02-03 13:24 ` [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver Dan Carpenter
2016-02-07 22:18 ` Greg KH
[not found] <BLU436-SMTP23BDE7B8746553D1EA0FFD80DB0@phx.gbl>
2016-01-29 17:32 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).