Re: [PATCH 7/7] drm/fsl-dcu: use mode flags for hsync/vsync pixelclk polarity

Thierry Reding
2016-02-03T14:04:42Z

[-- Attachment #1: Type: text/plain, Size: 1578 bytes --]

On Wed, Jan 27, 2016 at 06:46:50PM -0800, Stefan Agner wrote:
[...]
> On 2015-11-18 18:42, Stefan Agner wrote:
[...]
> > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
[...]
> > @@ -89,6 +91,15 @@ static void fsl_dcu_drm_crtc_mode_set_nofb(struct
> > drm_crtc *crtc)
> > vfp = mode->vsync_start - mode->vdisplay;
> > vsw = mode->vsync_end - mode->vsync_start;
> >
> > + if (!(mode->flags & DISPLAY_FLAGS_PIXDATA_POSEDGE))
> > + pol |= DCU_SYN_POL_INV_PXCK_FALL;
> > +
> > + if (mode->flags & DRM_MODE_FLAG_NHSYNC)
> > + pol |= DCU_SYN_POL_INV_HS_LOW;
> > +
> > + if (mode->flags & DRM_MODE_FLAG_NHSYNC)
> > + pol |= DCU_SYN_POL_INV_VS_LOW;

I suspect that you want to check for DRM_MODE_FLAG_NVSYNC here instead.

> > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h
> > b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h
> > index 6413ac9..2a724f3 100644
> > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h
> > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h
> > @@ -47,8 +47,8 @@
> > #define DCU_VSYN_PARA_FP(x) (x)
> >
> > #define DCU_SYN_POL 0x0024
> > -#define DCU_SYN_POL_INV_PXCK_FALL (0 << 6)
> > -#define DCU_SYN_POL_NEG_REMAIN (0 << 5)
> > +#define DCU_SYN_POL_INV_PXCK_FALL BIT(6)
> > +#define DCU_SYN_POL_NEG_REMAIN BIT(5)

I don't understand these changes. You're in fact changing the values for
these defines, but it's not mentioned in the commit message. It also
seems like it should be a separate patch because it isn't related to the
mode flags changes in the remainder of the patch.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]