From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933036AbcBCOEm (ORCPT ); Wed, 3 Feb 2016 09:04:42 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:36237 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932329AbcBCOEk (ORCPT ); Wed, 3 Feb 2016 09:04:40 -0500 Date: Wed, 3 Feb 2016 15:04:38 +0100 From: Thierry Reding To: Stefan Agner Cc: airlied@gmail.com, alison.wang@freescale.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, airlied@linux.ie, daniel.vetter@ffwll.ch, jianwei.wang.chn@gmail.com, Shawn Guo Subject: Re: [PATCH 7/7] drm/fsl-dcu: use mode flags for hsync/vsync pixelclk polarity Message-ID: <20160203140438.GB9650@ulmo> References: <1447900970-15936-1-git-send-email-stefan@agner.ch> <1447900970-15936-8-git-send-email-stefan@agner.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XOIedfhf+7KOe/yw" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XOIedfhf+7KOe/yw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 27, 2016 at 06:46:50PM -0800, Stefan Agner wrote: [...] > On 2015-11-18 18:42, Stefan Agner wrote: [...] > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c [...] > > @@ -89,6 +91,15 @@ static void fsl_dcu_drm_crtc_mode_set_nofb(struct > > drm_crtc *crtc) > > vfp =3D mode->vsync_start - mode->vdisplay; > > vsw =3D mode->vsync_end - mode->vsync_start; > > =20 > > + if (!(mode->flags & DISPLAY_FLAGS_PIXDATA_POSEDGE)) > > + pol |=3D DCU_SYN_POL_INV_PXCK_FALL; > > + > > + if (mode->flags & DRM_MODE_FLAG_NHSYNC) > > + pol |=3D DCU_SYN_POL_INV_HS_LOW; > > + > > + if (mode->flags & DRM_MODE_FLAG_NHSYNC) > > + pol |=3D DCU_SYN_POL_INV_VS_LOW; I suspect that you want to check for DRM_MODE_FLAG_NVSYNC here instead. > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h > > b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h > > index 6413ac9..2a724f3 100644 > > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h > > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h > > @@ -47,8 +47,8 @@ > > #define DCU_VSYN_PARA_FP(x) (x) > > =20 > > #define DCU_SYN_POL 0x0024 > > -#define DCU_SYN_POL_INV_PXCK_FALL (0 << 6) > > -#define DCU_SYN_POL_NEG_REMAIN (0 << 5) > > +#define DCU_SYN_POL_INV_PXCK_FALL BIT(6) > > +#define DCU_SYN_POL_NEG_REMAIN BIT(5) I don't understand these changes. You're in fact changing the values for these defines, but it's not mentioned in the commit message. It also seems like it should be a separate patch because it isn't related to the mode flags changes in the remainder of the patch. Thierry --XOIedfhf+7KOe/yw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWsgj2AAoJEN0jrNd/PrOhmNEP+wSkL9b2lHbczFg6uvc9VGHq 5pYTDbGBDYVqsro5fSoPtPdYaW2s3zLMP1Y7YYWKDqsGhzqo5J2mfgsO9utESN56 8k1OAiCMaQ5+CXsk1nEAUWWBEE9B4zFB1hxi0KkXkK0YHqA4dzc10QqIHQrq9biD AHvgAkGLXhBEC+Rfnaj57JAQrgtu2IZfiheKoXa8JG8aSNcF8Wx5Nbh9Ix+J3rlT 5wCNcfZpmEy9UevvzOAPylgVK+0CWup1eumoS5aqtzY9lfX6nMlJlpFkjQXDB+35 2lUVUw9E+a2nStvvnArab4A8lARgFUb3DKawvZtYh2ArGJYpQcYcsb/ljsQ/GzeM v7UVjwd6qJ4Nuax9sQQFPgXMWMwYM1vvy6lgYYggDKzkfJFEVrRhrKTiF83pDe5n ybFmp8mj8Vfrur2WxVB+xFwMJH0H2ma2xfavZdiRzgjEwvdqOKR/wts1IaEkrHvC f9EKJDDXzSGrusFzKe0yv76Zs70r0HVVm1//dsi+eOGUy6sYyA33ukYRzTQE7gpc 85+SrHch5+p3p5qIFsTDmqPAMqbXHvdAK8fuxgaxUQVLJWElgbhL0buuYxojVa0K L0X5MV0LN1DnBl8GkWCLrJ9Bqu6NW5vS967G93yzKthXigUG1y874W6VbvItevmG JhC8W7KhxFif5+cMZtBT =A6ez -----END PGP SIGNATURE----- --XOIedfhf+7KOe/yw--