From: Don Zickus <dzickus@redhat.com>
To: Jeffrey Merkey <jeffmerkey@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
atomlin@redhat.com, cmetcalf@ezchip.com, fweisbec@gmail.com,
hidehiro.kawai.ez@hitachi.com, mhocko@suse.cz, tj@kernel.org,
uobergfe@redhat.com
Subject: Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection
Date: Wed, 3 Feb 2016 10:47:58 -0500 [thread overview]
Message-ID: <20160203154758.GQ26637@redhat.com> (raw)
In-Reply-To: <CA+ekxPXUNBvS9QjKWLGo_0zXJ=-fbC_iry5Jcv4HVyE1hpRbsw@mail.gmail.com>
On Tue, Feb 02, 2016 at 03:40:34PM -0700, Jeffrey Merkey wrote:
> >
> > Please remember to add version history, so I can tell what changed.
> >
>
> What command do I give to git when it creates the patch from git
> format-patch that outputs what you are looking for or do I have to add
> that manually. The diff of files changed?
Sorry I forgot to respond to this part. This is usually just a manual text
that folks add to explain what changed between different versions of the
patch. It is difficult to re-review a patch from scratch all the time. It
is nice to have a little blurb stating what changed to help focus my review.
Now this patch is small enough, it doesn't matter, but it is a nice habit to
get into.
Cheers,
Don
next prev parent reply other threads:[~2016-02-03 15:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 2:33 [PATCH v5 1/3] Add BUG_XX() debugging options Jeffrey Merkey
2016-02-02 2:33 ` [PATCH v5 2/3] Add BUG_XX() debugging options Kconfig.debug Jeffrey Merkey
2016-02-02 2:33 ` [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Jeffrey Merkey
2016-02-02 17:30 ` Don Zickus
2016-02-02 22:40 ` Jeffrey Merkey
2016-02-03 4:17 ` Jeffrey Merkey
2016-02-03 4:39 ` Jeffrey Merkey
2016-02-03 15:45 ` Don Zickus
2016-02-03 17:23 ` Jeffrey Merkey
2016-02-03 20:14 ` Don Zickus
2016-02-03 20:18 ` Jeffrey Merkey
2016-02-04 2:48 ` Jeffrey Merkey
2016-02-03 15:47 ` Don Zickus [this message]
2016-02-03 17:26 ` Jeffrey Merkey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203154758.GQ26637@redhat.com \
--to=dzickus@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=atomlin@redhat.com \
--cc=cmetcalf@ezchip.com \
--cc=fweisbec@gmail.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=jeffmerkey@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox