From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757289AbcBCPsD (ORCPT ); Wed, 3 Feb 2016 10:48:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44426 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757241AbcBCPsA (ORCPT ); Wed, 3 Feb 2016 10:48:00 -0500 Date: Wed, 3 Feb 2016 10:47:58 -0500 From: Don Zickus To: Jeffrey Merkey Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, atomlin@redhat.com, cmetcalf@ezchip.com, fweisbec@gmail.com, hidehiro.kawai.ez@hitachi.com, mhocko@suse.cz, tj@kernel.org, uobergfe@redhat.com Subject: Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Message-ID: <20160203154758.GQ26637@redhat.com> References: <1454380428-31474-1-git-send-email-jeffmerkey@gmail.com> <1454380428-31474-3-git-send-email-jeffmerkey@gmail.com> <20160202173034.GG26637@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2016 at 03:40:34PM -0700, Jeffrey Merkey wrote: > > > > Please remember to add version history, so I can tell what changed. > > > > What command do I give to git when it creates the patch from git > format-patch that outputs what you are looking for or do I have to add > that manually. The diff of files changed? Sorry I forgot to respond to this part. This is usually just a manual text that folks add to explain what changed between different versions of the patch. It is difficult to re-review a patch from scratch all the time. It is nice to have a little blurb stating what changed to help focus my review. Now this patch is small enough, it doesn't matter, but it is a nice habit to get into. Cheers, Don