From: Matt Fleming <matt@codeblueprint.co.uk>
To: Dave Young <dyoung@redhat.com>
Cc: linux-efi@vger.kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/efi: skip bgrt init for kexec reboot
Date: Wed, 3 Feb 2016 22:53:33 +0000 [thread overview]
Message-ID: <20160203225333.GA31246@codeblueprint.co.uk> (raw)
In-Reply-To: <20160203214200.GA15110@dhcp-128-65.nay.redhat.com>
On Thu, 04 Feb, at 05:42:00AM, Dave Young wrote:
>
> On 01/27/16 at 07:20pm, Dave Young wrote:
> > For kexec reboot the bgrt image address could contains random data because
> > we have freed boot service areas in 1st kernel boot phase. One possible
> > result is kmalloc fail in efi_bgrt_init due to large random image size.
> >
> > So change efi_late_init to avoid efi_bgrt_init in case kexec boot.
> >
> > Signed-off-by: Dave Young <dyoung@redhat.com>
> > ---
> > arch/x86/platform/efi/efi.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > --- linux-x86.orig/arch/x86/platform/efi/efi.c
> > +++ linux-x86/arch/x86/platform/efi/efi.c
> > @@ -531,7 +531,8 @@ void __init efi_init(void)
> >
> > void __init efi_late_init(void)
> > {
> > - efi_bgrt_init();
> > + if (!efi_setup)
> > + efi_bgrt_init();
> > }
> >
> > void __init efi_set_executable(efi_memory_desc_t *md, bool executable)
>
> Matt, opinions about this patch?
Yeah, I'm not happy seeing efi_setup escaping into even more places,
nor am I happy to see more code paths introduced where kexec boot is
special-cased.
I'll reply with more details tomorrow.
next prev parent reply other threads:[~2016-02-03 22:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 11:20 [PATCH] x86/efi: skip bgrt init for kexec reboot Dave Young
2016-02-03 21:42 ` Dave Young
2016-02-03 22:53 ` Matt Fleming [this message]
2016-02-04 10:03 ` Matt Fleming
2016-02-04 11:09 ` Dave Young
2016-02-04 11:56 ` Matt Fleming
2016-02-05 0:41 ` Dave Young
2016-02-11 16:09 ` Matt Fleming
2016-02-12 12:45 ` Dave Young
2016-02-16 14:48 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203225333.GA31246@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).