From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965410AbcBDDqq (ORCPT ); Wed, 3 Feb 2016 22:46:46 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44929 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757621AbcBDDqo (ORCPT ); Wed, 3 Feb 2016 22:46:44 -0500 Date: Wed, 3 Feb 2016 19:46:43 -0800 From: Greg KH To: Emilio =?iso-8859-1?Q?L=F3pez?= Cc: stern@rowland.harvard.edu, kborer@gmail.com, bjorn@mork.no, reillyg@chromium.org, keescook@chromium.org, linux-api@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, jorgelo@chromium.org, dan.carpenter@oracle.com Subject: Re: [PATCH v3] usb: devio: Add ioctl to disallow detaching kernel USB drivers. Message-ID: <20160204034643.GA17786@kroah.com> References: <1453420476-26125-1-git-send-email-emilio.lopez@collabora.co.uk> <1454556057-18956-1-git-send-email-emilio.lopez@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1454556057-18956-1-git-send-email-emilio.lopez@collabora.co.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 04, 2016 at 12:20:57AM -0300, Emilio López wrote: > From: Reilly Grant > > The new USBDEVFS_DROP_PRIVILEGES ioctl allows a process to voluntarily > relinquish the ability to issue other ioctls that may interfere with > other processes and drivers that have claimed an interface on the > device. > > Signed-off-by: Reilly Grant > Signed-off-by: Emilio López > > --- > > Changes in v3: > - Switch ioctl to use a __u32 given the iface qty is capped at 32 > - Reword comments as requested by Alan > - Allow callers to shrink the allowed interfaces mask No documentation? Proof it works? Test scripts? This isn't a trivial feature to add, how do we know it is correct? thanks, greg k-h