From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966124AbcBDPe1 (ORCPT ); Thu, 4 Feb 2016 10:34:27 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:54614 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965316AbcBDPe0 (ORCPT ); Thu, 4 Feb 2016 10:34:26 -0500 X-Originating-IP: 50.39.163.18 Date: Thu, 4 Feb 2016 07:34:15 -0800 From: Josh Triplett To: "Michael Kerrisk (man-pages)" Cc: Andrew Morton , lkml , Linux API , Andy Lutomirski , Steven Rostedt , Greg Kroah-Hartman , Shuah Khan , Mauro Carvalho Chehab Subject: Re: [patch] MAINTAINERS: trim the file triggers for ABI/API Message-ID: <20160204153415.GB6066@x> References: <56B35A9F.1080303@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56B35A9F.1080303@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 04, 2016 at 03:05:19PM +0100, Michael Kerrisk (man-pages) wrote: > Josh Tripplett's commit ea8f8fc8631d9f890580a94d57a18bfeb827fa2e s/Tripplett/Triplett/ > was well intentioned (I even Acked it), but in practice it has mostly > generated (a lot of) useless noise on linux-api as developers of > drivers and implementers of other uninteresting changes run > scripts/get-maintainers.pl and unthinkingly paste the results > into their email clients. And that commit didn't really > help catch the really important API changes (new system calls, > new options to existing system calls, new pseudofile entries, > and so on). So, trim the 'F:' triggers for the "ABI/API" entry > in MAINTAINERS right back to the minimum. This change makes sense, but I don't think this commit message explains the specific changes to the file triggers. (Also, there's a convention for referencing past commits.) Might I suggest an alternate commit message? """ Commit ea8f8fc8631 ("MAINTAINERS: add linux-api for review of API/ABI changes") added file triggers for various paths that likely indicated API/ABI changes. However, catching all changes in Documentation/ABI/ and include/uapi/ produces a large volume of mail to linux-api, rather than only API/ABI changes. Drop those two entries, but leave include/linux/syscalls.h and kernel/sys_ni.c to catch syscall-related changes. """ > Signed-off-by: Michael Kerrisk > --- > MAINTAINERS | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index f678c37..56f7a4f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -223,9 +223,7 @@ F: drivers/scsi/aacraid/ > > ABI/API > L: linux-api@vger.kernel.org > -F: Documentation/ABI/ > F: include/linux/syscalls.h > -F: include/uapi/ > F: kernel/sys_ni.c > > ABIT UGURU 1,2 HARDWARE MONITOR DRIVER > -- > 2.5.0