From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965821AbcBDS51 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Feb 2016 13:57:27 -0500
Received: from down.free-electrons.com ([37.187.137.238]:40334 "EHLO
	mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S965756AbcBDS5X (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Feb 2016 13:57:23 -0500
Date: Thu, 4 Feb 2016 17:44:38 +0100
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Lee Jones <lee.jones@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH 10/11] ARM: dts: sun9i: a80-optimus: Disable dummy
 regulators vcc3v0, vcc3v3, vcc5v0
Message-ID: <20160204164438.GJ4270@lukather>
References: <1454408864-24112-1-git-send-email-wens@csie.org>
 <1454408864-24112-11-git-send-email-wens@csie.org>
 <20160202162136.GX4652@lukather>
 <CAGb2v66xjgsoVEBocUfDk6DDx4QcH-4pP94v+4FHLTJ=rii09Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="I/5syFLg1Ed7r+1G"
Content-Disposition: inline
In-Reply-To: <CAGb2v66xjgsoVEBocUfDk6DDx4QcH-4pP94v+4FHLTJ=rii09Q@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--I/5syFLg1Ed7r+1G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 03, 2016 at 12:41:37AM +0800, Chen-Yu Tsai wrote:
> On Wed, Feb 3, 2016 at 12:21 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Hi,
> >
> > On Tue, Feb 02, 2016 at 06:27:43PM +0800, Chen-Yu Tsai wrote:
> >> These 3 regulators are provided in sunxi-common-regulators.dtsi.
> >> 3.0V/3.3V and 5.0V are commonly used voltages in Allwinner devices.
> >> These dummy regulators provide a stand-in when bindings that require
> >> one, but the real regulator is not supported yet.
> >>
> >> Since these are no longer needed, we can disable them.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >
> > Why not remove the include entirely then?
>=20
> reg_vbus* are still used. Or should we move them as well?

I think so yeah. It's totally fine to disable per-boards regulators.

Maxime

--=20
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

--I/5syFLg1Ed7r+1G
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJWs3/2AAoJEBx+YmzsjxAgl5YQAIBO01JaOibCiypG6vHLR9X0
9OLwaIA1+z+p6Bh4Ndq+4TQlFdDsfGFWFucDFtIBhmEGrBKI0xsiLf6gN8U3MHpw
LhA7XK3catAIwXU8EDIwzpTSx/QQ6YnWg0cvsH4zRMJGCQn1IXwA07I+5vm//23q
q3uUP57GyOq+LE9TSsLPV/wja7fhWjmPbBcYC0A1y/iAtxzoXswRgiiTXyHrzvS+
k6bzvQTByAT3+0fBIBiR+/JUnM8Vi4Ltkx4+uEv1Zjs6GEyHYJ+tneQGddKYaf7a
LT+moy6FgEGPvNExqoYajgBjIRukTIXQAKcM2I7z/kmQD4I+IpPeD7MpXLn+afOU
g9CpcykFy0iEFxjtoFmb8bs/0EXl3KHEejVneMwdxuMc8fmZ5rDWl68fH8RjOgp3
LaRld9Ym+GFn9SZOJMYaYt2+IqgIluFTP4i9x8hxGrKgWAA3xJknzb5qTazUPNMX
aHBDBxFRYBI96WsFetz1zCV7miZH/IBmjsHX4ZvMtf1/u116precIBdeJUl7XyEV
IHNqdZWfOw/4W8Gus3Sgs+D1sxkoNMecNUDCqlEAhYapg1w31fZwtGegoxIZx3GD
+rMHfmUksR2+bL4+Kgox4XUO/IXO/6oGAgoZ2CbeL6HKPgQNRrgpSWNBSYJOh4Sc
8vgXuFyu413Y+UV7uKLn
=jG/K
-----END PGP SIGNATURE-----

--I/5syFLg1Ed7r+1G--