From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753541AbcBEOed (ORCPT <rfc822;w@1wt.eu>);
	Fri, 5 Feb 2016 09:34:33 -0500
Received: from foss.arm.com ([217.140.101.70]:48268 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752509AbcBEOec (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 5 Feb 2016 09:34:32 -0500
Date: Fri, 5 Feb 2016 14:34:04 +0000
From: Mark Rutland <mark.rutland@arm.com>
To: Laura Abbott <labbott@fedoraproject.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 3/3] arm64: ptdump: Indicate whether memory should be
 faulting
Message-ID: <20160205143403.GD19614@leverpostej>
References: <1454615017-24672-1-git-send-email-labbott@fedoraproject.org>
 <1454615017-24672-4-git-send-email-labbott@fedoraproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1454615017-24672-4-git-send-email-labbott@fedoraproject.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 04, 2016 at 11:43:37AM -0800, Laura Abbott wrote:
> 
> With CONFIG_DEBUG_PAGEALLOC, pages do not have the valid bit
> set when free in the buddy allocator. Add an indiciation to
> the page table dumping code that the valid bit is not set,
> 'F' for fault, to make this easier to understand.
> 
> Signed-off-by: Laura Abbott <labbott@fedoraproject.org>

This looks sensible to me, and worked in testing.

Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Tested-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/mm/dump.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
> index 5a22a11..f381ac9 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/dump.c
> @@ -90,6 +90,11 @@ struct prot_bits {
>  
>  static const struct prot_bits pte_bits[] = {
>  	{
> +		.mask	= PTE_VALID,
> +		.val	= PTE_VALID,
> +		.set	= " ",
> +		.clear	= "F",
> +	}, {
>  		.mask	= PTE_USER,
>  		.val	= PTE_USER,
>  		.set	= "USR",
> -- 
> 2.5.0
>