From: Bjorn Helgaas <helgaas@kernel.org>
To: Joao Pinto <Joao.Pinto@synopsys.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, Vineet.Gupta1@synopsys.com,
CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH v3] synopsys pcie rc generic platform driver update
Date: Fri, 5 Feb 2016 16:52:04 -0600 [thread overview]
Message-ID: <20160205225204.GB11780@localhost> (raw)
In-Reply-To: <28b04a32cc7caf6db542d4b5aa1feddacd02b2c9.1454701564.git.jpinto@synopsys.com>
Hi Joao,
On Fri, Feb 05, 2016 at 07:55:43PM +0000, Joao Pinto wrote:
> This patch tries to improve the host/pcie-synopsys branch including a new
> driver name, more accurate documentation and centralized link up validation.
> Other platform drivers were also updated to include the new centralized link
> up validation function.
It's true that I wanted you to incorporate a few tweaks I had made in
my pci/host-synopsys branch, but generating incremental patches on top
of that branch makes this too confusing to follow.
My pci/host-synopsys contains two patches on top of v4.5-rc1. I would
prefer that you
- fetch that branch,
- make whatever edits you need, and
- generate fresh patches based on v4.5-rc1
Then everybody can see the whole series at once without trying to
integrate these changes with the ones you've previously posted, and I
can start from scratch and apply those fresh patches on top of
v4.5-rc1.
It's good that you include summaries of what's changed between
versions, but if people want to see *exactly* what's changed between
your v3 and v4 postings, it's easy for them to download those series,
apply them on different branches, and git diff the branches.
Bjorn
next prev parent reply other threads:[~2016-02-05 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 19:55 [PATCH v3] synopsys pcie rc generic platform driver update Joao Pinto
2016-02-05 22:52 ` Bjorn Helgaas [this message]
2016-02-08 11:34 ` Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205225204.GB11780@localhost \
--to=helgaas@kernel.org \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox