From: Greg KH <gregkh@linuxfoundation.org>
To: Rahul Pathak <rahulpathaklinux@gmail.com>
Cc: jslaby@suse.com, samuel.thibault@ens-lyon.org, pavel@ucw.cz,
dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: vt: use memdup_user to reuse the code
Date: Sat, 6 Feb 2016 23:31:03 -0800 [thread overview]
Message-ID: <20160207073103.GA1311@kroah.com> (raw)
In-Reply-To: <20151219184533.GA7305@platform-Vostro-3546>
On Sun, Dec 20, 2015 at 12:15:33AM +0530, Rahul Pathak wrote:
> Fixing coccicheck warning which recommends to use memdup_user instead
> to reimplement its code, using memdup_user simplifies the code
>
> ./drivers/tty/vt/keyboard.c:1709:9-16: WARNING opportunity for memdup_user
> ./drivers/tty/vt/keyboard.c:1752:9-16: WARNING opportunity for memdup_user
>
> Signed-off-by: Rahul Pathak <rahulpathaklinux@gmail.com>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/tty/vt/keyboard.c | 28 ++++++++--------------------
> 1 file changed, 8 insertions(+), 20 deletions(-)
Someone else sent half of this patch already, can you redo it against my
tty-testing branch of the tty.git tree and resend it?
thanks,
greg k-h
next prev parent reply other threads:[~2016-02-07 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 18:45 [PATCH] tty: vt: use memdup_user to reuse the code Rahul Pathak
2015-12-21 20:04 ` Dmitry Torokhov
2016-02-07 7:31 ` Greg KH [this message]
2016-02-07 10:08 ` rahul pathak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160207073103.GA1311@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rahulpathaklinux@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).