From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753963AbcBGMee (ORCPT ); Sun, 7 Feb 2016 07:34:34 -0500 Received: from violet.fr.zoreil.com ([92.243.8.30]:35928 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751394AbcBGMec (ORCPT ); Sun, 7 Feb 2016 07:34:32 -0500 Date: Sun, 7 Feb 2016 13:34:26 +0100 From: Francois Romieu To: Robert Jarzmik Cc: netdev@vger.kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org, Sergei Shtylyov Subject: Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource Message-ID: <20160207123426.GA6022@electric-eye.fr.zoreil.com> References: <1454796693-4446-1-git-send-email-robert.jarzmik@free.fr> <20160207102303.GA4976@electric-eye.fr.zoreil.com> <87twlk3ija.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87twlk3ija.fsf@belgarion.home> X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Robert Jarzmik : > Francois Romieu writes: [...] > > If you have some spare time, it would be nice to avoid db->irq_wake leak > > on probe failure or driver removal. > Sorry but not in this patch. Of course. Different topic => different patch. > I suppose the right patch would be to use devm_*() in the probe function for > ioremaps and request_irqs, which would address this point. I'd rather avoid devm_* on netdev. -- Ueimor