linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	William Hubbs <w.d.hubbs@gmail.com>,
	Chris Brannon <chris@the-brannons.com>,
	Kirk Reiser <kirk@reisers.ca>,
	Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	speakup@linux-speakup.org,
	driverdevel <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300
Date: Sun, 7 Feb 2016 18:33:14 +0100	[thread overview]
Message-ID: <20160207173314.GQ3056@var.home> (raw)
In-Reply-To: <CAMuHMdXKj+KPhgMwihQbog8migVSwuycT8WRFQj5AkY1Or-Oqg@mail.gmail.com>

Geert Uytterhoeven, on Sun 07 Feb 2016 10:18:46 +0100, wrote:
> On Mon, Feb 1, 2016 at 9:06 AM, Samuel Thibault
> <samuel.thibault@ens-lyon.org> wrote:
> > mn10300 uses an mmio-driven uart. This is not supported by speakup, so
> > prevent from enabling it.
> 
> Just wondering, what are the symptoms of the failure?

It'll try to request the 0x00-0x08 ports and fail, returning -ENODEV.

> Is it a compile-time or run-time failure?

The fix is for compile-time. run-time failure will already return
-ENODEV.

> Is this about drivers/staging/speakup/serialio.c?

Yes.

This code is to be replaced anyway.

Samuel

  reply	other threads:[~2016-02-07 17:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01  8:06 [PATCH] Staging: speakup: Fix allyesconfig build on mn10300 Samuel Thibault
2016-02-01 20:46 ` Greg Kroah-Hartman
2016-02-07  9:18 ` Geert Uytterhoeven
2016-02-07 17:33   ` Samuel Thibault [this message]
2016-02-07 20:23   ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160207173314.GQ3056@var.home \
    --to=samuel.thibault@ens-lyon.org \
    --cc=aysemelikeyurtoglu@gmail.com \
    --cc=chris@the-brannons.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kirk@reisers.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=speakup@linux-speakup.org \
    --cc=w.d.hubbs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).