From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754505AbcBGRdV (ORCPT <rfc822;w@1wt.eu>);
	Sun, 7 Feb 2016 12:33:21 -0500
Received: from sonata.ens-lyon.org ([140.77.166.138]:37542 "EHLO
	sonata.ens-lyon.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754395AbcBGRdT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 7 Feb 2016 12:33:19 -0500
Date: Sun, 7 Feb 2016 18:33:14 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
        William Hubbs <w.d.hubbs@gmail.com>,
        Chris Brannon <chris@the-brannons.com>, Kirk Reiser <kirk@reisers.ca>,
        Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        speakup@linux-speakup.org, driverdevel <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300
Message-ID: <20160207173314.GQ3056@var.home>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	William Hubbs <w.d.hubbs@gmail.com>,
	Chris Brannon <chris@the-brannons.com>,
	Kirk Reiser <kirk@reisers.ca>,
	Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	speakup@linux-speakup.org, driverdevel <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20160201080603.GB4046@var>
 <CAMuHMdXKj+KPhgMwihQbog8migVSwuycT8WRFQj5AkY1Or-Oqg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMuHMdXKj+KPhgMwihQbog8migVSwuycT8WRFQj5AkY1Or-Oqg@mail.gmail.com>
User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Geert Uytterhoeven, on Sun 07 Feb 2016 10:18:46 +0100, wrote:
> On Mon, Feb 1, 2016 at 9:06 AM, Samuel Thibault
> <samuel.thibault@ens-lyon.org> wrote:
> > mn10300 uses an mmio-driven uart. This is not supported by speakup, so
> > prevent from enabling it.
> 
> Just wondering, what are the symptoms of the failure?

It'll try to request the 0x00-0x08 ports and fail, returning -ENODEV.

> Is it a compile-time or run-time failure?

The fix is for compile-time. run-time failure will already return
-ENODEV.

> Is this about drivers/staging/speakup/serialio.c?

Yes.

This code is to be replaced anyway.

Samuel