From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755082AbcBGWSQ (ORCPT ); Sun, 7 Feb 2016 17:18:16 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:56268 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754863AbcBGWSO (ORCPT ); Sun, 7 Feb 2016 17:18:14 -0500 Date: Sun, 7 Feb 2016 14:18:13 -0800 From: Greg KH To: Bijosh Thykkoottathil Cc: devel@driverdev.osuosl.org, adrianremonda@gmail.com, linux-kernel@vger.kernel.org, christian.gromm@microchip.com, sudipm.mukherjee@gmail.com, andrey.shvetsov@k2l.de Subject: Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver Message-ID: <20160207221813.GA6831@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 29, 2016 at 11:33:20PM +0530, Bijosh Thykkoottathil wrote: > Fixes following coding style issues reported by the check patch script. > - ERROR: Macros with complex values should be enclosed in parentheses > > Moving static storage class to the beginning of declaration fixes these > errors. Well that's a horrid fix for this, as you aren't doing anything different here. Fix the tool if it is reporting things incorrectly, don't blindly change code for no reason please. checkpatch isn't always correct, as you have found out. thanks, greg k-h