* [PATCH] staging: rtl8192e: prefer using eth_broadcast_addr()
@ 2016-01-20 13:06 Gujulan Elango, Hari Prasath (H.)
2016-02-08 4:01 ` gregkh
0 siblings, 1 reply; 2+ messages in thread
From: Gujulan Elango, Hari Prasath (H.) @ 2016-01-20 13:06 UTC (permalink / raw)
To: gregkh@linuxfoundation.org, mateusz.kulikowski@gmail.com,
vthakkar1994@gmail.com, DHANAPAL, GNANACHANDRAN (G.)
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
From: Hari Prasath Gujulan Elango
Prefer using the eth_broadcast_addr() instead of memset to broadcast
address 0xFF to the array.
Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
---
drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index d0fedb0..2a57640 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -355,9 +355,9 @@ static inline struct sk_buff *rtllib_probe_req(struct rtllib_device *ieee)
req->header.frame_ctl = cpu_to_le16(RTLLIB_STYPE_PROBE_REQ);
req->header.duration_id = 0;
- memset(req->header.addr1, 0xff, ETH_ALEN);
+ eth_broadcast_addr(req->header.addr1);
ether_addr_copy(req->header.addr2, ieee->dev->dev_addr);
- memset(req->header.addr3, 0xff, ETH_ALEN);
+ eth_broadcast_addr(req->header.addr3);
tag = (u8 *) skb_put(skb, len + 2 + rate_len);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8192e: prefer using eth_broadcast_addr()
2016-01-20 13:06 [PATCH] staging: rtl8192e: prefer using eth_broadcast_addr() Gujulan Elango, Hari Prasath (H.)
@ 2016-02-08 4:01 ` gregkh
0 siblings, 0 replies; 2+ messages in thread
From: gregkh @ 2016-02-08 4:01 UTC (permalink / raw)
To: Gujulan Elango, Hari Prasath (H.)
Cc: mateusz.kulikowski@gmail.com, vthakkar1994@gmail.com,
DHANAPAL, GNANACHANDRAN (G.), devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
On Wed, Jan 20, 2016 at 01:06:13PM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> From: Hari Prasath Gujulan Elango
When you do this, you need an email address after the name, otherwise
git complains and refuses to apply the patch.
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-08 4:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-20 13:06 [PATCH] staging: rtl8192e: prefer using eth_broadcast_addr() Gujulan Elango, Hari Prasath (H.)
2016-02-08 4:01 ` gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).