From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755440AbcBHEoR (ORCPT ); Sun, 7 Feb 2016 23:44:17 -0500 Received: from mail-db3on0124.outbound.protection.outlook.com ([157.55.234.124]:47136 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753979AbcBHEoQ convert rfc822-to-8bit (ORCPT ); Sun, 7 Feb 2016 23:44:16 -0500 From: "Gujulan Elango, Hari Prasath (H.)" To: "gregkh@linuxfoundation.org" , "hal.mateusz.kulikowski@gmail.com" , "vthakkar1994@gmail.com" CC: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: [PATCHv2] staging: rtl8192e: prefer using eth_broadcast_addr() Thread-Topic: [PATCHv2] staging: rtl8192e: prefer using eth_broadcast_addr() Thread-Index: AQHRYitb2j58SgtDW0qvwFTifF8Bsg== Date: Mon, 8 Feb 2016 04:44:13 +0000 Message-ID: <20160208044523.GA14294@IND12F0122> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dmarc=none action=none header.from=visteon.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [91.212.132.118] x-microsoft-exchange-diagnostics: 1;DB5PR06MB1576;5:vLKNhB6p3ug9aGlRiWL/14Iq2nMivlsA92ROpJ/WjjakpilUWYgg86vT0myXWAP2fArDUK6+eCvuIk66hsEdVDW7bdVq9a4NmiI0QjffV3U3WmbKhiYE0bD0GTOG2uE8hV6cnOniK5FN7f/CQkHQIw==;24:bEmHpd8NErcUetqbI0l2Dj2HYe3F/B7dcWCCcKp7cNch4xwzqNoYorhLaDS8dgDW9vyZ+KFLjppunH43OALaKFarEPRg0aaYL5br4RMG6cs= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1576; x-ms-office365-filtering-correlation-id: fa007289-8729-4f5b-33da-08d330427e59 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(208512329853888); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:DB5PR06MB1576;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1576; x-forefront-prvs: 084674B2CF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(106116001)(1220700001)(1076002)(1096002)(229853001)(5008740100001)(2501003)(86362001)(575784001)(2906002)(11100500001)(586003)(3660700001)(10400500002)(3280700002)(4326007)(5001960100002)(54356999)(50986999)(33656002)(2201001)(19580395003)(77096005)(33716001)(5001770100001)(92566002)(189998001)(19580405001)(5004730100002)(5002640100001)(102836003)(3846002)(122556002)(40100003)(87936001)(66066001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR06MB1576;H:DB5PR06MB1573.eurprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2016 04:44:13.3715 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR06MB1576 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hari Prasath Gujulan Elango Prefer using the eth_broadcast_addr() instead of memset to broadcast address 0xFF to the array. Signed-off-by: Hari Prasath Gujulan Elango --- v2: From email address was missing as pointed by Greg. --- drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index d0fedb0..2a57640 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -355,9 +355,9 @@ static inline struct sk_buff *rtllib_probe_req(struct rtllib_device *ieee) req->header.frame_ctl = cpu_to_le16(RTLLIB_STYPE_PROBE_REQ); req->header.duration_id = 0; - memset(req->header.addr1, 0xff, ETH_ALEN); + eth_broadcast_addr(req->header.addr1); ether_addr_copy(req->header.addr2, ieee->dev->dev_addr); - memset(req->header.addr3, 0xff, ETH_ALEN); + eth_broadcast_addr(req->header.addr3); tag = (u8 *) skb_put(skb, len + 2 + rate_len); -- 1.9.1