From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751150AbcBHJHS (ORCPT ); Mon, 8 Feb 2016 04:07:18 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:35270 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbcBHJHO (ORCPT ); Mon, 8 Feb 2016 04:07:14 -0500 Date: Mon, 8 Feb 2016 10:07:36 +0100 From: Daniel Vetter To: Patrik Jakobsson Cc: Alan , wuninsu@gmail.com, linux-kernel , dri-devel Subject: Re: [PATCH] gma500: clean up an excessive and confusing helper Message-ID: <20160208090736.GW11240@phenom.ffwll.local> Mail-Followup-To: Patrik Jakobsson , Alan , wuninsu@gmail.com, linux-kernel , dri-devel References: <20160129193731.8475.47809.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2016 at 09:11:51AM +0100, Patrik Jakobsson wrote: > On Fri, Jan 29, 2016 at 8:37 PM, Alan wrote: > > From: Alan Cox > > > > This is a left over from the great clean ups in the past. It's confusing as > > it returns an int, yet has one caller that never uses it. The caller already > > has all the right private variables local so the entire function can be > > replaced by a simple if call. > > > > Signed-off-by: Alan Cox > > Signed-off-by: Patrik Jakobsson Applied to drm-misc, thanks. -Daniel > > > --- > > drivers/gpu/drm/gma500/framebuffer.c | 20 ++++---------------- > > 1 file changed, 4 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c > > index cb95765..033d894 100644 > > --- a/drivers/gpu/drm/gma500/framebuffer.c > > +++ b/drivers/gpu/drm/gma500/framebuffer.c > > @@ -674,29 +674,17 @@ static const struct drm_mode_config_funcs psb_mode_funcs = { > > .output_poll_changed = psbfb_output_poll_changed, > > }; > > > > -static int psb_create_backlight_property(struct drm_device *dev) > > -{ > > - struct drm_psb_private *dev_priv = dev->dev_private; > > - struct drm_property *backlight; > > - > > - if (dev_priv->backlight_property) > > - return 0; > > - > > - backlight = drm_property_create_range(dev, 0, "backlight", 0, 100); > > - > > - dev_priv->backlight_property = backlight; > > - > > - return 0; > > -} > > - > > static void psb_setup_outputs(struct drm_device *dev) > > { > > struct drm_psb_private *dev_priv = dev->dev_private; > > struct drm_connector *connector; > > > > drm_mode_create_scaling_mode_property(dev); > > - psb_create_backlight_property(dev); > > > > + /* It is ok for this to fail - we just don't get backlight control */ > > + if (!dev_priv->backlight_property) > > + dev_priv->backlight_property = drm_property_create_range(dev, 0, > > + "backlight", 0, 100); > > dev_priv->ops->output_init(dev); > > > > list_for_each_entry(connector, &dev->mode_config.connector_list, > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch