From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752036AbcBHJxZ (ORCPT ); Mon, 8 Feb 2016 04:53:25 -0500 Received: from down.free-electrons.com ([37.187.137.238]:59686 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751231AbcBHJxY (ORCPT ); Mon, 8 Feb 2016 04:53:24 -0500 Date: Mon, 8 Feb 2016 10:53:22 +0100 From: Thomas Petazzoni To: Marc Zyngier Cc: Antoine Tenart , tglx@linutronix.de, jason@lakedaemon.net, tsahee@annapurnalabs.com, rshitrit@annapurnalabs.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller Message-ID: <20160208105322.78b20cba@free-electrons.com> In-Reply-To: <56B86391.1030609@arm.com> References: <1454922971-17405-1-git-send-email-antoine.tenart@free-electrons.com> <1454922971-17405-2-git-send-email-antoine.tenart@free-electrons.com> <56B86391.1030609@arm.com> Organization: Free Electrons X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Marc, On Mon, 8 Feb 2016 09:44:49 +0000, Marc Zyngier wrote: > > +static struct msi_domain_info alpine_msix_domain_info = { > > + .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | > > + MSI_FLAG_PCI_MSIX, > > You can probably add MSI_FLAG_PCI_MSI, it should work as well (MULTI_MSI > obviously won't). Why wouldn't MULTI_MSI work? The code is using bitmap_find_next_zero_area() in alpine_msix_allocate_sgi() precisely to find num_req consecutive bits set to 0, in order to allocate multiple MSIs at once. Am I missing something? Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com