From: Ingo Molnar <mingo@kernel.org>
To: PaX Team <pageexec@freemail.hu>
Cc: linux-tip-commits@vger.kernel.org, zhangyanfei@cn.fujitsu.com,
wency@cn.fujitsu.com, tglx@linutronix.de,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
imtangchen@gmail.com, spender@grsecurity.net, hpa@zytor.com,
tangchen@cn.fujitsu.com, y14sg1@comcast.net,
isimatu.yasuaki@jp.fujitsu.com, akpm@linux-foundation.org,
izumi.taku@jp.fujitsu.com, laijs@cn.fujitsu.com
Subject: Re: [tip:x86/mm] x86/mm/numa: Clean up numa_clear_kernel_node_hotplug ()
Date: Mon, 8 Feb 2016 12:18:08 +0100 [thread overview]
Message-ID: <20160208111808.GA8870@gmail.com> (raw)
In-Reply-To: <56B86F95.12384.11AF6415@pageexec.freemail.hu>
* PaX Team <pageexec@freemail.hu> wrote:
> On 8 Feb 2016 at 1:42, tip-bot for Ingo Molnar wrote:
>
> > for (i = 0; i < numa_meminfo.nr_blks; i++) {
> > - struct numa_memblk *mb = &numa_meminfo.blk[i];
> > + struct numa_memblk *mb = numa_meminfo.blk + i;
> >
> > - memblock_set_node(mb->start, mb->end - mb->start,
> > - &memblock.reserved, mb->nid);
> > + memblock_set_node(mb->start, mb->end-mb->start, &memblock.reserved, mb->nid);
>
> if you're not keeping to the 80-char length (no complaints from me on that), could
> you also use some whitespace around the '-' operator for more readability?
Yeah, like I did it later in the function:
+ memblock_clear_hotplug(mb->start, mb->end - mb->start);
Fixed.
Thanks,
Ingo
prev parent reply other threads:[~2016-02-08 11:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-f0d954d0c31cc59bb2d0b63a75632cf8d17cca5a@git.kernel.org>
2016-02-08 10:36 ` [tip:x86/mm] x86/mm/numa: Clean up numa_clear_kernel_node_hotplug () PaX Team
2016-02-08 11:18 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208111808.GA8870@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=imtangchen@gmail.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=pageexec@freemail.hu \
--cc=spender@grsecurity.net \
--cc=tangchen@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wency@cn.fujitsu.com \
--cc=y14sg1@comcast.net \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).