* Re: [tip:x86/mm] x86/mm/numa: Clean up numa_clear_kernel_node_hotplug ()
[not found] <tip-f0d954d0c31cc59bb2d0b63a75632cf8d17cca5a@git.kernel.org>
@ 2016-02-08 10:36 ` PaX Team
2016-02-08 11:18 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: PaX Team @ 2016-02-08 10:36 UTC (permalink / raw)
To: linux-tip-commits, zhangyanfei, wency, tglx, torvalds,
linux-kernel, mingo, imtangchen, spender, hpa, tangchen, y14sg1,
isimatu.yasuaki, akpm, izumi.taku, laijs
Cc: izumi.taku, torvalds, tglx, akpm, wency, zhangyanfei,
isimatu.yasuaki, y14sg1, tangchen, hpa, laijs, imtangchen,
spender, mingo
On 8 Feb 2016 at 1:42, tip-bot for Ingo Molnar wrote:
> for (i = 0; i < numa_meminfo.nr_blks; i++) {
> - struct numa_memblk *mb = &numa_meminfo.blk[i];
> + struct numa_memblk *mb = numa_meminfo.blk + i;
>
> - memblock_set_node(mb->start, mb->end - mb->start,
> - &memblock.reserved, mb->nid);
> + memblock_set_node(mb->start, mb->end-mb->start, &memblock.reserved, mb->nid);
if you're not keeping to the 80-char length (no complaints from me on that), could
you also use some whitespace around the '-' operator for more readability?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [tip:x86/mm] x86/mm/numa: Clean up numa_clear_kernel_node_hotplug ()
2016-02-08 10:36 ` [tip:x86/mm] x86/mm/numa: Clean up numa_clear_kernel_node_hotplug () PaX Team
@ 2016-02-08 11:18 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2016-02-08 11:18 UTC (permalink / raw)
To: PaX Team
Cc: linux-tip-commits, zhangyanfei, wency, tglx, torvalds,
linux-kernel, imtangchen, spender, hpa, tangchen, y14sg1,
isimatu.yasuaki, akpm, izumi.taku, laijs
* PaX Team <pageexec@freemail.hu> wrote:
> On 8 Feb 2016 at 1:42, tip-bot for Ingo Molnar wrote:
>
> > for (i = 0; i < numa_meminfo.nr_blks; i++) {
> > - struct numa_memblk *mb = &numa_meminfo.blk[i];
> > + struct numa_memblk *mb = numa_meminfo.blk + i;
> >
> > - memblock_set_node(mb->start, mb->end - mb->start,
> > - &memblock.reserved, mb->nid);
> > + memblock_set_node(mb->start, mb->end-mb->start, &memblock.reserved, mb->nid);
>
> if you're not keeping to the 80-char length (no complaints from me on that), could
> you also use some whitespace around the '-' operator for more readability?
Yeah, like I did it later in the function:
+ memblock_clear_hotplug(mb->start, mb->end - mb->start);
Fixed.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-08 11:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tip-f0d954d0c31cc59bb2d0b63a75632cf8d17cca5a@git.kernel.org>
2016-02-08 10:36 ` [tip:x86/mm] x86/mm/numa: Clean up numa_clear_kernel_node_hotplug () PaX Team
2016-02-08 11:18 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).