From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755281AbcBHPyM (ORCPT ); Mon, 8 Feb 2016 10:54:12 -0500 Received: from mail1.windriver.com ([147.11.146.13]:35334 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754257AbcBHPyJ (ORCPT ); Mon, 8 Feb 2016 10:54:09 -0500 Date: Mon, 8 Feb 2016 10:53:56 -0500 From: Paul Gortmaker To: Arnd Bergmann CC: , Jingoo Han , Pratyush Anand , Bjorn Helgaas , Geert Uytterhoeven , Stanimir Varbanov , Thierry Reding , Subject: Re: [PATCH 3/5] drivers/pci: export dw syms enabling board specific PCI code to be tristate Message-ID: <20160208155356.GV23093@windriver.com> References: <1454889644-27830-1-git-send-email-paul.gortmaker@windriver.com> <1454889644-27830-4-git-send-email-paul.gortmaker@windriver.com> <4185524.RaOx11t2l7@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4185524.RaOx11t2l7@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Re: [PATCH 3/5] drivers/pci: export dw syms enabling board specific PCI code to be tristate] On 08/02/2016 (Mon 10:57) Arnd Bergmann wrote: > On Sunday 07 February 2016 19:00:42 Paul Gortmaker wrote: > > After converting the drivers who select PCI_DW from bool to tristate, > > the following symbols need to be exported, simply based on the output > > from modpost failures. > > > > Cc: Jingoo Han > > Cc: Pratyush Anand > > Cc: Bjorn Helgaas > > Cc: Geert Uytterhoeven > > Cc: Stanimir Varbanov > > Cc: Thierry Reding > > Cc: Arnd Bergmann > > Cc: linux-pci@vger.kernel.org > > Signed-off-by: Paul Gortmaker > > > > Looks good in principle, but maybe use EXPORT_SYMBOL_GPL? These > are just meant to be used internally by the drivers after all. Sure, I can make that restriction. P. -- > > Arnd