From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reset: sunxi: Make reset_control_ops const
Date: Mon, 8 Feb 2016 16:59:57 +0100 [thread overview]
Message-ID: <20160208155957.GH31506@lukather> (raw)
In-Reply-To: <1454938141-9976-1-git-send-email-p.zabel@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
Hi Philipp,
On Mon, Feb 08, 2016 at 02:29:01PM +0100, Philipp Zabel wrote:
> The sunxi_reset_ops structure is never modified. Make it const.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/reset/reset-sunxi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
> index 8d41a18..677f865 100644
> --- a/drivers/reset/reset-sunxi.c
> +++ b/drivers/reset/reset-sunxi.c
> @@ -70,7 +70,7 @@ static int sunxi_reset_deassert(struct reset_controller_dev *rcdev,
> return 0;
> }
>
> -static struct reset_control_ops sunxi_reset_ops = {
> +static const struct reset_control_ops sunxi_reset_ops = {
> .assert = sunxi_reset_assert,
> .deassert = sunxi_reset_deassert,
> };
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-02-08 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 13:29 [PATCH] reset: sunxi: Make reset_control_ops const Philipp Zabel
2016-02-08 14:50 ` kbuild test robot
2016-02-08 15:59 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208155957.GH31506@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox