From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932382AbcBHQdr (ORCPT ); Mon, 8 Feb 2016 11:33:47 -0500 Received: from www.linutronix.de ([62.245.132.108]:33316 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932297AbcBHQdn (ORCPT ); Mon, 8 Feb 2016 11:33:43 -0500 Date: Mon, 8 Feb 2016 17:33:41 +0100 From: Sebastian Andrzej Siewior To: linux-rt-users@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, Steven Rostedt Subject: [PATCH RT] mm: backing-dev: don't disable IRQs in wb_congested_put() Message-ID: <20160208163341.GA15956@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org it triggers: |BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:930 |in_atomic(): 0, irqs_disabled(): 1, pid: 12, name: rcuc/0 |1 lock held by rcuc/0/12: | #0: (rcu_callback){......}, at: [] rcu_cpu_kthread+0x376/0xb10 |irq event stamp: 23636 |hardirqs last enabled at (23635): [] _raw_spin_unlock_irqrestore+0x6c/0x80 |hardirqs last disabled at (23636): [] wb_congested_put+0x18/0x90 | [] rt_spin_lock+0x24/0x60 | [] atomic_dec_and_spin_lock+0x52/0x90 | [] wb_congested_put+0x28/0x90 | [] __blkg_release_rcu+0x5e/0x1e0 | [] ? __blkg_release_rcu+0x87/0x1e0 | [] ? blkg_conf_finish+0x90/0x90 | [] rcu_cpu_kthread+0x3b7/0xb10 due to cgwb_lock beeing taken with spin_lock_irqsave() usually. Signed-off-by: Sebastian Andrzej Siewior --- mm/backing-dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/backing-dev.c b/mm/backing-dev.c index 7340353f8aea..b2ca2908b808 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -457,9 +457,9 @@ void wb_congested_put(struct bdi_writeback_congested *congested) { unsigned long flags; - local_irq_save(flags); + local_irq_save_nort(flags); if (!atomic_dec_and_lock(&congested->refcnt, &cgwb_lock)) { - local_irq_restore(flags); + local_irq_restore_nort(flags); return; } -- 2.7.0